[bfcache] Add notRestoredReasons field in PerformanceNavigationTiming #35764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 2, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3835534
branch
6 times, most recently
from
bce3383
to
c71fb7d
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3835534
branch
5 times, most recently
from
70cbb30
to
a827235
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3835534
branch
11 times, most recently
from
be870a3
to
dfc55d7
Compare
This CL adds back/forward cache not restored reasons in Performance NavigationTiming API. It's proposed here: w3c/navigation-timing#171 Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md This CL does two things: - exposes not restored reasons to PerformanceNavigationTiming API - adds WPT The WPT have to run on all platforms because this API is intended to collect bfcache metrics from the wild, regardless of the platforms. LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields Bug: 1349228 Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835534 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Weizhong Xia <weizhong@google.com> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/main@{#1054800}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3835534
branch
from
dfc55d7
to
73b8418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds back/forward cache not restored reasons in Performance
NavigationTiming API.
It's proposed here:
w3c/navigation-timing#171
Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md
This CL does two things:
The WPT have to run on all platforms because this API is intended to
collect bfcache metrics from the wild, regardless of the platforms.
LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields
Bug: 1349228
Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835534
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Weizhong Xia <weizhong@google.com>
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1054800}