Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building Problem #142

Open
Tianle-hub opened this issue Oct 25, 2023 · 4 comments
Open

Building Problem #142

Tianle-hub opened this issue Oct 25, 2023 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@Tianle-hub
Copy link

  1. Fail building because of the gym version, change to 0.22.0 then works
    image

  2. Fail building for poetry, use "main" instead of "master" then works
    requires = ["poetry-core @ git+https://github.com/python-poetry/poetry-core.git@main"]
    image

@Federico-PizarroBejarano
Copy link
Contributor

Hello @TaneliLab, thank you for your interest in our gym. Are you sure you have pulled the latest version of the code? I see you are using version 0.5.0 of the repo but we are now on version 2.0.0. In the latest code I believe we have fixed this issues.

  1. We are no longer using gym but instead using gymnasium:
    gymnasium = "^0.28"
  2. I believe we fixed this a while ago, and now it should be using main instead of master there:
    requires = ["poetry-core @ git+https://github.com/python-poetry/poetry-core.git@main"]

Please let me know if this is the problem!

@Tianle-hub
Copy link
Author

Thanks, I was using beta-iros-competition branch. It builds successfully on main :)

@Federico-PizarroBejarano
Copy link
Contributor

No worries! @JacopoPan idk if you plan on updating any issues on that branch or if we just leave it as is?

@JacopoPan
Copy link
Member

Hi @TaneliLab and @Federico-PizarroBejarano, I would hold changing beta-iros-competition because it is one of the branches still currently used by @spencerteetaert @Williamwenda for data collection.

I would then want to move the SITL support from safe-control-gym/beta-iros-competition to gym-pybullet-drones/main.

We should leave this issue open for temporary reference.

@JacopoPan JacopoPan added the help wanted Extra attention is needed label Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants