chore(smart-contracts): cleanup tests from remains of Truffle #13365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemsos
commented
Feb 22, 2024
clemsos
commented
Mar 1, 2024
|
Ok, this is a big PR, so hard to review! But since this is mostly refactors, we can just check that the same amount of tests are running. This is the output on a successful recent build on |
clemsos
force-pushed
the
cleanup-web3-tests
branch
from
29d657b
to
17b254a
Compare
|
Currently we got 939 passing (8m) Before refactoring:
|
clemsos
force-pushed
the
cleanup-web3-tests
branch
from
97eca88
to
acf8b21
Compare
|
@julien51 we should be good to go here ! |
|
ok, I am looking at the coverage also, I have been trying to run this locally from |
julien51
approved these changes
Mar 5, 2024
| beforeEach(async () => { | ||
| ;[, , , { address: someAccount }] = await ethers.getSigners() |
There was a problem hiding this comment.
If we don't really care what that is maybe we can rather just create a random one?
|
I was in fact able to run it after cleaning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are still places in the tests where we use patterns like
artifacts.requirethat originated in using web3/Truffle some years ago. This PR removes them.Issues
Refs #12843
Checklist:
Release Note Draft Snippet