New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(smart-contracts): cleanup tests from remains of Truffle #13365
Merged
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
e92040f
refactor hook tests
clemsos c228074
some more hooks
clemsos 41cc8e6
udt tests
clemsos bfdd217
add note to clean that up
clemsos 95269b9
fix some more tests
clemsos f8cc399
more fixes
clemsos 9f5bf00
parse multiple signatures correctly
clemsos 3b5e6f0
remove truffle fixture from main deployment task
clemsos fc364af
all deployed locks are ethers
clemsos 12af8f4
all deployed ERC20 are ethers
clemsos 7310d93
refactor behaviors tests
clemsos c558649
fix erc721 tests
clemsos 8ece691
remove BigNumber.js balance helper
clemsos d9f6d84
fix some more balance helpers
clemsos 31e905d
deploy all locks using truffle by default
clemsos c862009
some more changes in Unlock tests
clemsos e3c85cd
refactor gas tests
clemsos f4baf56
keyManager tests
clemsos 4fe0409
fix all permissions scripts
clemsos bf03f4e
cleanup some mroe
clemsos c005713
fix a bunch more
clemsos 2bc973a
fix more tests
clemsos af2ed4e
fix tests again
clemsos a5633d6
behaviors fixes
clemsos 0a324cd
skip grant tokens test by default
clemsos fef43ba
use qualified path
clemsos 885a69c
skip grant tokens test entirely
clemsos ac85915
fix tokenURI test
clemsos fb48db9
actually no need to skip
clemsos b70e8a5
remove truffle from hardhat config - replace all `contract(` by `desc…
clemsos 74a5ee8
remove outdated OZ test helpers
clemsos d0aa745
fix remaining artifacts/accounts patterns
clemsos 4d2e90e
literal import of `assert`
clemsos 18e5c6c
bunch of fixes
clemsos 2b1a214
cleanup package.json
clemsos cf3f74f
one last test
clemsos b2e392e
delete unsued file
clemsos acf8b21
skip grant tokens on coverage (missing baseFee)
clemsos File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't really care what that is maybe we can rather just create a
random
one?