Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of legacy tooling in smart-contracts tests #12843

Closed
clemsos opened this issue Oct 20, 2023 · 3 comments
Closed

Cleanup of legacy tooling in smart-contracts tests #12843

clemsos opened this issue Oct 20, 2023 · 3 comments
Assignees
Labels
💰bounty There's a bounty on this issue!

Comments

@clemsos
Copy link
Member

clemsos commented Oct 20, 2023

We still have legacy tools in our smart contracts test suite that should be removed to make everything more consistent and maintainable

@clemsos clemsos added the 💰bounty There's a bounty on this issue! label Oct 26, 2023
@clemsos
Copy link
Member Author

clemsos commented Nov 25, 2023

Regarding outdated Truffle patterns, the major changes are:

  • artifacts.require replaced by ethers.getContractFactory
  • ˋaccounts addresses replaced by ˋethers.getSigners
  • use the ethers signers with ˋconnect() instead of passing ˋfrom in functions calls
  • replace instances of ˋbignumber.jslib by ethersBigNumber`. We introduced helpers to facilitate bn comparisons in chore(smart-contracts): remove chai + bignumber pattern from tests #12851

Some examples of such changes are demonstrated in #12699

@clemsos
Copy link
Member Author

clemsos commented Feb 2, 2024

see also errors for ethers v6 for context

@clemsos
Copy link
Member Author

clemsos commented Mar 5, 2024

done in #13365

@clemsos clemsos closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💰bounty There's a bounty on this issue!
Projects
None yet
Development

No branches or pull requests

1 participant