feat: update template basis #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the need for the page-plugin.php file and overhauls the base.twig, head.twig and footer.twig
This was referenced May 2, 2024
Merged
gchtr
approved these changes
May 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Issue
Since the creation of the starter theme a lot has happened in PHP, WordPress and Timber. I want to make the starter-theme a more modern starting point for custom theme development.
Especially the base.twig and the need for the header and footer bothered me.
Solution
This particular PR focusses on removing the need for the header.php and footer.php by calling the proper actions from the twig files. While working on the base.twig I renamed html-header.twig to head.twig, moved some code tags around, removed some obsolete tags and made it overall a better starting point.
Impact
people coming from older versions of the timber-theme need to recalibrate a bit on how to work with this new setup.
Usage Changes
No
Considerations
I also removed some strange code blocks that, in my opinion, were distracting. For example the top
{% block html_head_container %} {% endblock %}has been renamed and the the inner block has been removed. We could move that block to the head.twig file if needed. But if you are customizing the theme in such a way, you know what you are doing and can probably do it yourself?
Testing
no