feat: remove sidebar #153
Merged
feat: remove sidebar #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Issue
Since the creation of the starter theme a lot has happened in PHP, WordPress and Timber. I want to make the starter-theme a more modern starting point for custom theme development.
Solution
This particular PR focusses on deleting the sidebar files. Since Gutenberg is introduced, I rarely see widgets being used in the wild. With widgets getting deprecated, I think it is time to say farewell to the sidebar.
Impact
No more sidebars, so cleaner code.
Usage Changes
Minimal, I think when you create a new site nowaydays, developers are not using the sidebar/widgets functions that much. For the few folks that still stick to it, the can re-add this functionality in a way they see fit.
Considerations
Not dumping the sidebar yet?
Testing
I might try to add some overall tests in the upcoming few PR's