Feat: update composer file #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 2, 2024
Merged
gchtr
approved these changes
May 14, 2024
| @@ -1,12 +1,32 @@ | |||
| { | |||
| "name": "upstatement/timber-starter-theme", | |||
| "name": "timber/starter-theme", | |||
There was a problem hiding this comment.
This would require us to re-add it to packagist.org, right?
There was a problem hiding this comment.
I think it does, I think that it would make sense though. And then @jarednova has to deprecate the old version from @Upstatement to point to the new one.
There was a problem hiding this comment.
Yes, it makes sense :). I just wanted to make sure we keep track of this todo.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Issue
Since the creation of the starter theme a lot has happened in PHP, WordPress and Timber. I want to make the starter-theme a more modern starting point for custom theme development.
Solution
This particular PR focusses on bringing the starter theme under the timber umbrella at packagist.org, set the authors and a non-dev version of Timber.
Impact
Better composer file :D
Usage Changes
No
Considerations
Not moving the theme underneath the Timber account at packagist?
Testing
no