Maintainer Tips

Do

• Enlist other developers to help with review

• Commit patches with git am -m so that the Message-Id tag is added, and commitbot knows to respond to the patch

• Use git am -i so you can review and edit the message if needed

• Use git pull --no-ff --log when merging patchsets, so you get a merge commit, and a summary of the merged commits

• Scan the diffstat to ensure the submitter did not make a mistake

• Add Reviewed-By:, Tested-By: and other *-By: tags to commit logs

• Use git cherry-pick -x when backporting to maintain a link between the backported patch and its origin

• use git notes add -m 'backport: 1.1, 1.2' (and then git push origin refs/notes/commits) to note that a patch has been backported

Do not

• Merge your own patches without another reviewer (with the exception of trivial patches)