[wip] Bugfix for bag_split event callbacks called to early with file compression #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelOrlov
changed the title
MichaelOrlov
changed the title
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
- It is a non-virtual method and doesn't call from the base class. Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
force-pushed
the
morlov/bugfix-for-bag_split_callbacks-with-compression
branch
from
843ca1d
to
1d6249c
Compare
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
|
@MichaelOrlov do we have a reproducer for the problem that is fixed here? |
|
@r7vme Nop, that is the point. We need a regression test coverage to make sure that fix works as expected and that no one will brake it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rosbag2_cpp::Writer. i.e. callbacks calling when the bag file closes. However, the expected behavior is that callbacks are called when compression is finished and the original bag file is deleted.