Update sqlite-amalgamation into CMakeLists.txt #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosfet80
requested review from
emersonknapp and
hidmic
and removed request for
a team
clalancette
requested changes
Apr 16, 2024
Update sqlite-amalgamation Signed-off-by: mosfet80 <realeandrea@yahoo.it> Update CMakeLists.txt Signed-off-by: mosfet80 <realeandrea@yahoo.it> Update CMakeLists.txt Signed-off-by: mosfet80 <realeandrea@yahoo.it>
MichaelOrlov
requested changes
Apr 16, 2024
Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: mosfet80 <realeandrea@yahoo.it>
MichaelOrlov
requested changes
Apr 28, 2024
There was a problem hiding this comment.
@mosfet80 Thank you for addressing our comments per review. LGTM.
Could you please fix DCO?
https://github.com/ros2/rosbag2/pull/1611/checks?check_run_id=24298443545
|
@mosfet80 Friendly ping here to fix DCO in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sqlite-amalgamation