[WIP] Make Player a rosbag2 component (instead of rosbag2_transport
#1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roncapat
changed the title
rosbag2 componentrosbag2 component (instead of rosbag2_transport
MichaelOrlov
changed the title
rosbag2 component (instead of rosbag2_transportrosbag2 component (instead of rosbag2_transport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to address https://github.com/ros2/rosbag2/pull/1510/files#r1484600093.
CC @MichaelOrlov @fujitatomoya
NOTE: I compiled it and the component gets correclty exposed via
ros2 component typesbut I haven't tested it yet.If it works, I extend it also to
Recorderand then it's ready for merge.