More precise type hints for rosbag2_py
#1463
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VERY WIP
Meant to address #1459
For now, the only improved type hint is for
SequentialReader.read_nextand the type stubs need to be generated manually.This branch has many other changes I made to make development easier for me. I'm guessing
rosbag2doesn't actually want them, in which case they'd be removed before this PR is un-drafted.These changes are:
.devcontainerandDockerfile. Currently these mention my username. If the devcontainer is kept, I'd remove that username-specific bit. These were made following this guide for getting ROS2 in a devcontainer.rosbag2_pynow useunittest.TestCase, so that I can run them from the VSCode test panel, without running the entirecolcon test..githubworkflows (you definitely don't want this change)