Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sharing NG] Share date is missing in new API #8749

Closed
JammingBen opened this issue Mar 27, 2024 · 3 comments · Fixed by #8954
Closed

[Sharing NG] Share date is missing in new API #8749

JammingBen opened this issue Mar 27, 2024 · 3 comments · Fixed by #8954
Assignees
@fschade @JammingBen

Comments

@JammingBen
Copy link
Contributor

The share date (=date when a share has been created) is currently missing in the API. As briefly discussed on Monday, we are currently not sure if we need it. Web uses it for 2 reasons:

  • Sort the shares in the right sidebar. This way we can display recent shares at the top of the list.
  • Display the share date in the resource table for incoming shares.

I'd say both things are quite helpful for the user. Could someone (tm) please estimate how much effort it would be to add this to the API? Then we can make a decision on how to proceed.
@JammingBen JammingBen mentioned this issue Mar 27, 2024
Open
41 tasks
@JammingBen
Copy link
Contributor Author

@micbar @tbsbdr @rhafer Can me make a decision if we want to continue having a share date in the future? Then I can plan for it in Web accordingly.

As stated above, I'd like to have it for the above mentioned reasons.

@tbsbdr
Copy link

tbsbdr commented Apr 12, 2024

My opinion:

  • if the implementation effort in the backend is less than 1pd, I'd buy it

@micbar
Copy link
Contributor

micbar commented Apr 15, 2024

I think we store the property anyways because we need it to calculate the expiration.

let’s add it.

@JammingBen JammingBen mentioned this issue Apr 15, 2024
Closed
7 tasks
This was referenced Apr 24, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fschade fschade

@JammingBen JammingBen

Labels
None yet
Projects
Infinite Scale Team Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhancement: inject the creation time into sharing permissions fschade/ocis
4 participants
@micbar @tbsbdr @fschade @JammingBen