enhancement: inject the creation time into sharing permissions #8954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
JammingBen
force-pushed
the
graph-permission-c-time
branch
from
96fff88
to
f74a820
Compare
JammingBen
force-pushed
the
graph-permission-c-time
branch
from
f74a820
to
26b1ba6
Compare
JammingBen
force-pushed
the
graph-permission-c-time
branch
from
26b1ba6
to
f34bb51
Compare
7 tasks
|
micbar
approved these changes
Apr 29, 2024
ownclouders
pushed a commit
that referenced
this pull request
Apr 29, 2024
enhancement: inject the creation time into sharing permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the graph permission object lacks a creation date-time, which is needed by the client, be careful, that property is NOT part of the official MS-Graph spec.
Related Issue
Motivation and Context
not sure about the motivation, specially since that is not part of the official spec, please lets discuss what we do (extent the spec, creep the spec or something similar like we do with the
@UI.Hidden) -> we decided to mark this as libre graph only in the spec.Types of changes
Checklist: