enhancement: add creation time to the permission object #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fschade
requested review from
dragotin,
butonic,
micbar,
kulmann and
rhafer
as code owners
9 tasks
2403905
previously approved these changes
Apr 24, 2024
rhafer
requested changes
Apr 24, 2024
api/openapi-spec/v1.0.yaml
Outdated
| @@ -4963,6 +4963,11 @@ components: | |||
| description: An optional expiration date which limits the permission in time. | |||
| format: date-time | |||
| nullable: true | |||
| creationDateTime: | |||
| type: string | |||
| description: An optional creation date. | |||
There was a problem hiding this comment.
Please at a note here, that this is libregraph only.
There was a problem hiding this comment.
Actually I was referring to add the note the the description. Like we do e.g. here:
https://github.com/owncloud/libre-graph-api/blob/main/api/openapi-spec/v1.0.yaml#L4222
fschade
force-pushed
the
permission-c-time
branch
from
5db5f93
to
cc78aac
Compare
rhafer
requested changes
Apr 25, 2024
api/openapi-spec/v1.0.yaml
Outdated
| @@ -4963,6 +4963,11 @@ components: | |||
| description: An optional expiration date which limits the permission in time. | |||
| format: date-time | |||
| nullable: true | |||
| creationDateTime: | |||
| type: string | |||
| description: An optional creation date. | |||
There was a problem hiding this comment.
Actually I was referring to add the note the the description. Like we do e.g. here:
https://github.com/owncloud/libre-graph-api/blob/main/api/openapi-spec/v1.0.yaml#L4222
fschade
force-pushed
the
permission-c-time
branch
from
cc78aac
to
bb37690
Compare
rhafer
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the c-time is not part of the official ms spec, that means were extending the permission object with a creationDateTime object property.
not sure how we proceed with that (not part of the official spec), lets discuss it here!
Needed by: owncloud/ocis#8749