Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement riscv_vlen_asm for riscv32 #24270

Closed
wants to merge 1 commit into from
Closed

Implement riscv_vlen_asm for riscv32 #24270

wants to merge 1 commit into from

Conversation

ZenithalHourlyRate
Copy link
Contributor

Now for the linux32-riscv32 target, we would get the error when linking

riscvcap.c:(.text.startup+0x104): undefined reference to `riscv_vlen_asm'

#20149 added riscv_vlen_asm in riscv64cpuid.pl but not in riscv32cpuid.pl, and this function is needed in riscvcap.c.

Checklist

@ZenithalHourlyRate
Implement riscv_vlen_asm for riscv32
89ca207 
riscvcap.c: undefined reference to 'riscv_vlen_asm'
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Apr 26, 2024
@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug severity: regression The issue/pr is a regression from previous released version tests: exempted The PR is exempt from requirements for testing branch: 3.3 Merge to openssl-3.3 labels Apr 26, 2024
@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Apr 26, 2024
shahsb
shahsb approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@shahsb shahsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ZenithalHourlyRate
Copy link
Contributor Author

Wonder if anything should be done for this PR

@t8m t8m requested a review from a team May 7, 2024 09:46
@t8m
Copy link
Member

t8m commented May 7, 2024

ping @openssl/committers for second review

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 8, 2024
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels May 9, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented May 10, 2024

Merged to the master and 3.3 branches. Thank you for your contribution.

@t8m t8m closed this May 10, 2024
openssl-machine pushed a commit that referenced this pull request May 10, 2024
@ZenithalHourlyRate @t8m
Implement riscv_vlen_asm for riscv32
87314d2 
riscvcap.c: undefined reference to 'riscv_vlen_asm'

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24270)
openssl-machine pushed a commit that referenced this pull request May 10, 2024
@ZenithalHourlyRate @t8m
Implement riscv_vlen_asm for riscv32
8702320 
riscvcap.c: undefined reference to 'riscv_vlen_asm'

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24270)

(cherry picked from commit 87314d2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

@shahsb shahsb shahsb approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.3 Merge to openssl-3.3 severity: fips change The pull request changes FIPS provider sources severity: regression The issue/pr is a regression from previous released version tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ZenithalHourlyRate @t8m @openssl-machine @paulidale @shahsb