MGMT-15736: Align feature support level to support HighAvailabilityMode #6077
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@eifrach: This pull request references MGMT-15736 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eifrach The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@eifrach: This pull request references MGMT-15736 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
removed
the
size/L
|
@eifrach: This pull request references MGMT-15736 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
size/XL
eifrach
force-pushed
the
feature_support_level_HighAvailabilityMode
branch
from
d96b28a
to
f67e73d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6077 +/- ##
==========================================
+ Coverage 68.22% 68.31% +0.08%
==========================================
Files 242 242
Lines 35884 35861 -23
==========================================
+ Hits 24481 24497 +16
+ Misses 9276 9233 -43
- Partials 2127 2131 +4
|
|
/test edge-subsystem-aws |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
eifrach
force-pushed
the
feature_support_level_HighAvailabilityMode
branch
from
2060376
to
622776b
Compare
|
/test edge-subsystem-kubeapi-aws |
eifrach
force-pushed
the
feature_support_level_HighAvailabilityMode
branch
from
6c984bb
to
511aebf
Compare
|
/test edge-subsystem-kubeapi-aws |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/test edge-e2e-vsphere-assisted |
|
/test edge-subsystem-aws |
|
@eifrach can you add the response of
|
| @@ -104,10 +101,14 @@ func GetFeatureSupportList(openshiftVersion string, cpuArchitecture *string, pla | |||
|
|
|||
| // IsFeatureAvailable Get the support level of a given feature, cpuArchitecture is optional | |||
| // with default value of x86_64 | |||
| func IsFeatureAvailable(featureId models.FeatureSupportLevelID, openshiftVersion string, cpuArchitecture *string) bool { | |||
| func IsFeatureAvailable(featureId models.FeatureSupportLevelID, openshiftVersion string, cpuArchitecture *string, highAvailabilityMode *string) bool { | |||
| if highAvailabilityMode == nil { | |||
There was a problem hiding this comment.
in which case we will get highAvailabilityMode == nil?
There was a problem hiding this comment.
if not configured, mostly in API call for featuresupport - but also subsystem test and unit tests
| - in: query | ||
| name: high_availability_mode | ||
| type: string | ||
| enum: [ 'Full', 'None' ] |
There was a problem hiding this comment.
would it make sense to set a default value? We would get rid of all the nil checks
There was a problem hiding this comment.
do you mean create a new value which will be default ?
@gamli75 sound good, do you feel the same way?
note this will require some more work to revert and tests fixes
There was a problem hiding this comment.
I was more questioning if we really need this parameter to be optional. AFAIK only the UI uses this endpoint, so I was hoping they would set it all the time since the high availability parameter is set at cluster creation, and cannot be updated afterwards.
There was a problem hiding this comment.
I also saw that when we create a cluster the default value is full, see: https://github.com/openshift/assisted-service/blob/master/swagger.yaml#L4758
|
@eifrach: This pull request references MGMT-15736 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
done |
eifrach
force-pushed
the
feature_support_level_HighAvailabilityMode
branch
2 times, most recently
from
8394643
to
64757e3
Compare
|
rebase and retest |
eifrach
force-pushed
the
feature_support_level_HighAvailabilityMode
branch
from
64757e3
to
a5b582a
Compare
eifrach
force-pushed
the
feature_support_level_HighAvailabilityMode
branch
from
a5b582a
to
674fc2c
Compare
…de as filterable feature fixing errors in featuresupportlevel fixing feature support unit test fix formating - unittest passed blocking Nutanix and vSphere on SNO change support level for odf change Get support level func fix platform support unspported LVM multinode before 4.15 block platform from None mode fixing empth value for test format fixing tests fix lint error fixing all tests fixing all tests
openshift-ci
bot
added
the
do-not-merge/work-in-progress
eifrach
force-pushed
the
feature_support_level_HighAvailabilityMode
branch
from
674fc2c
to
58657c1
Compare
|
/test edge-subsystem-kubeapi-aws |
|
@eifrach: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
example
Request:
High Availability = None
Response
{ "features": { "BAREMETAL_PLATFORM": "supported", "CLUSTER_MANAGED_NETWORKING": "unavailable", "CNV": "supported", "CUSTOM_MANIFEST": "supported", "DUAL_STACK": "supported", "DUAL_STACK_VIPS": "supported", "EXTERNAL_PLATFORM": "supported", "EXTERNAL_PLATFORM_OCI": "tech-preview", "FULL_ISO": "supported", "LSO": "supported", "LVM": "supported", "MCE": "supported", "MINIMAL_ISO": "supported", "NONE_PLATFORM": "supported", "NUTANIX_INTEGRATION": "unavailable", "ODF": "unavailable", "OVN_NETWORK_TYPE": "supported", "SDN_NETWORK_TYPE": "unavailable", "SINGLE_NODE_EXPANSION": "supported", "SKIP_MCO_REBOOT": "supported", "SNO": "supported", "USER_MANAGED_NETWORKING": "supported", "VIP_AUTO_ALLOC": "unavailable", "VSPHERE_INTEGRATION": "unavailable" } }Request:
High Availability = Full
Response:
{ "features": { "BAREMETAL_PLATFORM": "supported", "CLUSTER_MANAGED_NETWORKING": "supported", "CNV": "supported", "CUSTOM_MANIFEST": "supported", "DUAL_STACK": "supported", "DUAL_STACK_VIPS": "supported", "EXTERNAL_PLATFORM": "supported", "EXTERNAL_PLATFORM_OCI": "tech-preview", "FULL_ISO": "supported", "LSO": "supported", "LVM": "supported", "MCE": "supported", "MINIMAL_ISO": "supported", "NONE_PLATFORM": "supported", "NUTANIX_INTEGRATION": "supported", "ODF": "supported", "OVN_NETWORK_TYPE": "supported", "SDN_NETWORK_TYPE": "unavailable", "SINGLE_NODE_EXPANSION": "supported", "SKIP_MCO_REBOOT": "supported", "SNO": "supported", "USER_MANAGED_NETWORKING": "supported", "VIP_AUTO_ALLOC": "unavailable", "VSPHERE_INTEGRATION": "supported" } }List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist