MGMT-15736: Align feature support level to support HighAvailabilityMode as filterable feature #5473
Conversation
|
@eliorerz: This pull request references MGMT-15736 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@eliorerz: GitHub didn't allow me to request PR reviews from the following users: eliorerz. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eliorerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
eliorerz
force-pushed
the
MGMT-15736_Align_feature_support_level_to_support_HighAvailabilityMode_as_filterable_feature
branch
from
2598dd0
to
3b5159d
Compare
|
/test edge-unit-test edge-subsystem-aws edge-subsystem-kubeapi-aws |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5473 +/- ##
==========================================
+ Coverage 67.63% 68.46% +0.82%
==========================================
Files 232 232
Lines 33988 35397 +1409
==========================================
+ Hits 22989 24235 +1246
- Misses 8951 9067 +116
- Partials 2048 2095 +47
|
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@eliorerz: This pull request references MGMT-15736 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
eliorerz
force-pushed
the
MGMT-15736_Align_feature_support_level_to_support_HighAvailabilityMode_as_filterable_feature
branch
2 times, most recently
from
b291553
to
8d1ddf7
Compare
| @@ -22,6 +22,10 @@ func (feature *SnoFeature) GetName() string { | |||
| } | |||
|
|
|||
| func (feature *SnoFeature) getSupportLevel(filters SupportLevelFilters) models.SupportLevel { | |||
| if filters.HighAvailabilityMode != nil { | |||
| return "" | |||
There was a problem hiding this comment.
I don't understand why you are doing this, can you explain?
There was a problem hiding this comment.
Sure, when returning empty string as support level it is not included in the response
There was a problem hiding this comment.
But I'll try to implement something more clear
| Expect(len(list)).To(Equal(16)) | ||
| } | ||
| }) | ||
| It("GetFeatureSupportList 4.12 with HighAvailabilityMode", func() { |
There was a problem hiding this comment.
| It("GetFeatureSupportList 4.12 with HighAvailabilityMode", func() { | |
| It("GetFeatureSupportList 4.12 with HighAvailabilityModeNone", func() { |
There was a problem hiding this comment.
This test check the features count if HighAvailabilityMode is set, this test is not HighAvailabilityModeNone specific
| OpenshiftVersion: "4.12", | ||
| CPUArchitecture: nil, | ||
| PlatformType: nil, | ||
| HighAvailabilityMode: swag.String(models.ClusterHighAvailabilityModeNone), |
There was a problem hiding this comment.
do we have another test with ClusterHighAvailabilityModeFull that should return a different length number of the list?
There was a problem hiding this comment.
If HighAvailabilityMode is set, it doesn't matter what is the value
|
/retest |
eliorerz
force-pushed
the
MGMT-15736_Align_feature_support_level_to_support_HighAvailabilityMode_as_filterable_feature
branch
from
8d1ddf7
to
0f0dfcb
Compare
…de as filterable feature
eliorerz
force-pushed
the
MGMT-15736_Align_feature_support_level_to_support_HighAvailabilityMode_as_filterable_feature
branch
from
0f0dfcb
to
db440e8
Compare
openshift-ci
bot
added
size/XL
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test ? |
|
@eliorerz: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test edge-e2e-oci-assisted edge-e2e-metal-assisted-none |
|
/test edge-e2e-nutanix-assisted |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@eliorerz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
duplicate #6077 |
|
@eifrach: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add parameter to
api/assisted-install/v2/support-levels/featuresAPI so that the features could be filtered also byhigh_availability_mod, e.g.List all the issues related to this PR
What environments does this code impact?
How was this code tested?
/cc @eliorerz