Skip to content

Commit

Permalink
fix review suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
eifrach committed Apr 10, 2024
1 parent 37f232f commit 58657c1
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion client/installer/get_supported_features_parameters.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions internal/featuresupport/features_networking.go
Expand Up @@ -7,7 +7,7 @@ import (
"github.com/openshift/assisted-service/internal/common"
"github.com/openshift/assisted-service/internal/network"
"github.com/openshift/assisted-service/models"
"k8s.io/utils/strings/slices"
"github.com/thoas/go-funk"
)

// VipAutoAllocFeature
Expand All @@ -30,7 +30,7 @@ func (feature *VipAutoAllocFeature) getSupportLevel(filters SupportLevelFilters)
string(models.PlatformTypeExternal),
string(models.PlatformTypeNone),
}
if filters.PlatformType != nil && slices.Contains(
if filters.PlatformType != nil && funk.Contains(
unavailablePlatform, string(*filters.PlatformType)) {
return models.SupportLevelUnavailable
}
Expand Down
4 changes: 2 additions & 2 deletions restapi/embedded_spec.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion swagger.yaml
Expand Up @@ -3724,7 +3724,7 @@ paths:
name: high_availability_mode
type: string
enum: [ 'Full', 'None' ]
description: Guaranteed availability of the installed cluster. 'Full' installs a Highly-Available cluster over multiple master nodes whereas 'None' installs a full cluster over one node.
description: Guaranteed availability of the installed cluster. 'Full' installs a Highly-Available cluster over multiple master nodes whereas 'None' installs a cluster over one node.
responses:
"200":
description: Success.
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 58657c1

Please sign in to comment.