Added check that parameter name matches fully #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauricioabreu
requested changes
Apr 19, 2020
| @@ -86,6 +86,18 @@ | |||
| http://media.example.com/fileSequence52-3.ts | |||
| ''' | |||
|
|
|||
| PLAYLIST_WITH_CUSTOM_MEDIA_HEADER = '''#EXTM3U | |||
There was a problem hiding this comment.
I think you can name it PLAYLIST_WITH_CUSTOM_TAG because your code fixes every custom tag, not just EXT-X-MEDIA. Do you agree?
| @@ -273,6 +273,10 @@ def test_session_key_attribute_without_initialization_vector(): | |||
| assert None == obj.session_keys[0].iv | |||
|
|
|||
|
|
|||
| def test_parse_custom_media_header(): | |||
| obj = m3u8.M3U8(playlists.PLAYLIST_WITH_CUSTOM_MEDIA_HEADER) | |||
There was a problem hiding this comment.
I think we should expect this test to assert something. I get it does not break, but what happens with the EXT-X-MEDIA-READY? Does it go away? Does it get parsed?
| @@ -271,6 +271,9 @@ def _parse_attribute_list(prefix, line, atribute_parser): | |||
| params = ATTRIBUTELISTPATTERN.split(line.replace(prefix + ':', ''))[1::2] | |||
|
|
|||
| attributes = {} | |||
| if not line.startswith(prefix+':') : | |||
There was a problem hiding this comment.
Nice catch! Could you remove that extra black space before the last colon?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I've encountered m3u8 playlist with custom header:
#EXT-X-MEDIA-READY:7f659f6f09bce196d7This header is erroneously parsed as
#EXT-X-MEDIAheader and gives this error:ValueError: not enough values to unpack (expected 2, got 1)at parser.py: 275
I think you should check that parameter string starts with exact parameter name, not just part of it.
Here is PR that fixes this.
test is also provided.