-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added check that parameter name matches fully #201
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -86,6 +86,18 @@ | |
http://media.example.com/fileSequence52-3.ts | ||
''' | ||
|
||
PLAYLIST_WITH_CUSTOM_MEDIA_HEADER = '''#EXTM3U | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you can name it |
||
#EXT-X-VERSION:3 | ||
#EXT-X-TARGETDURATION:6 | ||
#EXT-X-MEDIA-SEQUENCE:1 | ||
#EXT-X-MEDIA-READY:7f659f6f09bce196d7 | ||
#EXT-X-KEY:METHOD=AES-128,URI="[KEY]",IV=[IV] | ||
#EXTINF:6.0, | ||
https://cdn.example.com/vod/hash:XXX/file.mp4/media-1.ts | ||
#EXTINF:6.28, | ||
https://cdn.example.com/vod/hash:XXX/file.mp4/media-2.ts | ||
''' | ||
|
||
PLAYLIST_WITH_SESSION_ENCRYPTED_SEGMENTS = ''' | ||
#EXTM3U | ||
#EXT-X-MEDIA-SEQUENCE:7794 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -273,6 +273,10 @@ def test_session_key_attribute_without_initialization_vector(): | |
assert None == obj.session_keys[0].iv | ||
|
||
|
||
def test_parse_custom_media_header(): | ||
obj = m3u8.M3U8(playlists.PLAYLIST_WITH_CUSTOM_MEDIA_HEADER) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should expect this test to assert something. I get it does not break, but what happens with the EXT-X-MEDIA-READY? Does it go away? Does it get parsed? |
||
|
||
|
||
def test_segments_attribute(): | ||
obj = m3u8.M3U8(playlists.SIMPLE_PLAYLIST) | ||
mock_parser_data(obj, {'segments': [{'uri': '/foo/bar-1.ts', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Could you remove that extra black space before the last colon?