Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXT-X-GAP support #203

Merged
merged 1 commit into from
Apr 22, 2020
Merged

EXT-X-GAP support #203

merged 1 commit into from
Apr 22, 2020

Conversation

davemevans
Copy link
Contributor

As defined https://tools.ietf.org/html/draft-pantos-hls-rfc8216bis-05#section-4.4.2.7 and in the draft LLHLS extensions.

Crafted during these long COVID nights ...

@davemevans
Copy link
Contributor Author

davemevans commented Apr 20, 2020 •
edited

Hmm, the test failure relates to test_daterange_simple which hasn't changed here.
That test passed with the same test setup in eg https://travis-ci.org/github/globocom/m3u8/jobs/675005951 (via #201) 😕
Looking at the test again, the reliance on parse ordering is probably a bit suspect, but I still don't understand why the failure is intermittent ...

@mauricioabreu
Copy link
Member

@davemevans not sure what is going on with the tests.
I will merge it anyways. Thank you for all your hard work on this project.

@mauricioabreu mauricioabreu merged commit b071688 into globocom:master Apr 22, 2020
@davemevans davemevans deleted the GapSupport branch April 22, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandromoreira leandromoreira leandromoreira approved these changes

@mauricioabreu mauricioabreu Awaiting requested review from mauricioabreu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davemevans @mauricioabreu @leandromoreira