New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Intel MCG_CAP MSR update on switch #957
base: develop
Are you sure you want to change the base?
Conversation
Thanks for the contribution. There's a few things that need fixed before we can merge this.
The easiest to fix all these problems would be with the following: # Install our pre-commit hook with our install script.
./util/pre-commit-install.sh
# Run the hook on your commit and change the message.
git commit --amend In your editor interface, change the commit message to read
Save and close the editor. The Change-Id will be automatically added by the git hook. You can verify this with You can then force push the change with: git push -f origin gem5
# Via `git log`, make not of the commit's SHA.
# Here I'll use '{SHA}' as a placeholder.
# Go to the develop branch of your git repository.
git switch develop
# Add the mainline gem5 repo as a remote repo and fetch it.
git remote add upstream https://github.com/gem5/gem5.git
git fetch upstream
# Merge the upstream develop into your local develop branch.
git merge upstream/develop
# Create a new branch, from develop, for this change.
git switch -c pr-957-update
# Cherry Pick your change on top of this new branch.
git cherry-pick <SHA>
# Do a force push to this branch (i.e. https://github.com/Gem5Fork/gem5-fixintelmc/tree/stable).
git push -f origin stable |
Change-Id: I2d53cfb97ba4a48da027b5c86e602b6b4baa35a8 reason: https://www.intel.com/content/dam/develop/external/us/en/documents/335592-sdm-vol-4.pdf (2-30)
I have identified __mcheck_cpu_cap_init writes a kernel variable so that the capacity check is actually done with the initial value of the msr: MCG_CAP thus we need to change the value before kvm starts, in short this is not ready yet. |
Hi @Foxy-Boxes, what is the status of this PR? Thanks. |
Reason: https://www.intel.com/content/dam/develop/external/us/en/documents/335592-sdm-vol-4.pdf 2-30.