Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests,docker: Drop support for GCC <v11 and Clang <v14 #1020

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

BobbyRBruce
Copy link
Member

apt install gcc in Ubuntu 22.04 gives version 11, and apt install clang gives version 14. If we are to remove support for Ubuntu 20.04 (#798), there is little justification in maintaining support for compiler versions before then.

If we are to drop support for Ubuntu 20.04
(gem5#798) then we can drop support for
<v11 of GCC and <v14 of Clang as Ubuntu 22.04's apt installs v11 and v14
of GCC and Clang respectively by default.

Change-Id: I6a84c62b842f0a65150e5bb1a245fd22f4b0aef1
This works by building all GCC and Clang images on top of the 24.04
all-dependencies image. Fortunately 24.04 apt has all the gcc and clang
versions we support (assuming support for 20.04 is dropped).

This simplication is also more efficient. Each image only needs to `apt
install` the compiler (instead of all the dependencies needed, as
before).

Change-Id: Iefd3677a0e1e62ca86a6c92a616f39d4caef4c5b
Change-Id: I4cb86a25c493e27aaebeb8aff964a0f69abcd84a
@BobbyRBruce BobbyRBruce added util-docker Docker util files. That found in "utils/docker" github gem5 files necessary for GitHub integration. Found in ".github" labels Apr 14, 2024
Copy link
Contributor

@powerjg powerjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea seems fine to me. I didn't look in detail at the PR, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github gem5 files necessary for GitHub integration. Found in ".github" util-docker Docker util files. That found in "utils/docker"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants