[8.14] [Infra][APM] Fix uptime links display condition in Infra and APM (#181425) #181973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stic#181425) closes [elastic#178714](elastic#178714) ## Summary This PR changes where link to legacy uptime is displayed to conditionally show it according to whether the plugin is enabled or not. <img width="962" alt="image" src="https://github.com/elastic/kibana/assets/2767137/e2e659ae-bc2e-49a6-a34b-9434f04b4617"> <img width="962" alt="image" src="https://github.com/elastic/kibana/assets/2767137/4aa487f5-4a61-4387-a9ed-12c9ed624410"> ### How to test The issue and the fix are the same in serverless and stateful #### APM - Run ``` node scripts/synthtrace simple_trace.ts --from=now-15m --to=now --clean --target=http://elastic_serverless:changeme@localhost:9200 --kibana=http://elastic_serverless:changeme@0.0.0.0:5601 ``` - Navigate to APM > Traces, click on "Investigate" - if `xpack.legacy_uptime.enabled: false` in kibana.yml - "Status" **should** appear - if `xpack.legacy_uptime.enabled: false` in kibana.yml - "Status" **should not** appear - if `xpack.legacy_uptime.enabled: false` and `xpack.uptime.enabled: true` in kibana.yml - "Status" **should not** appear - if `observability:enableLegacyUptimeApp` is switched on in Advanced settings - "Status" **should** appear #### Infra - Start a local kibana instance pointing to an oblt cluster - Navigate to Infrastructure, select `Kubernetes Pod` (other asset types, except hosts, share the same code) in `Show` dropdown - if `xpack.legacy_uptime.enabled: false` in kibana.yml - the link should be **enabled** - if `xpack.legacy_uptime.enabled: false` in kibana.yml - the link to uptime should be **disabled** - if `xpack.legacy_uptime.enabled: false` and `xpack.uptime.enabled: true` in kibana.yml - the link to uptime should be **disabled** - if `observability:enableLegacyUptimeApp` is switched on in Advanced settings - the link to uptime should be **enabled** --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 694acf7)
botelastic
bot
added
the
Team:obs-ux-infra_services
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.14:Questions ?
Please refer to the Backport tool documentation