Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[8.14] [Infra][APM] Fix uptime links display condition in Infra and A…
…PM (#181425) (#181973) # Backport This will backport the following commits from `main` to `8.14`: - [[Infra][APM] Fix uptime links display condition in Infra and APM (#181425)](#181425) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"crespocarlos@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-04-29T12:06:03Z","message":"[Infra][APM] Fix uptime links display condition in Infra and APM (#181425)\n\ncloses [#178714](#178714 Summary\r\n\r\nThis PR changes where link to legacy uptime is displayed to\r\nconditionally show it according to whether the plugin is enabled or not.\r\n\r\n<img width=\"962\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2767137/e2e659ae-bc2e-49a6-a34b-9434f04b4617\">\r\n\r\n<img width=\"962\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2767137/4aa487f5-4a61-4387-a9ed-12c9ed624410\">\r\n\r\n\r\n### How to test\r\n\r\nThe issue and the fix are the same in serverless and stateful\r\n\r\n#### APM \r\n- Run\r\n```\r\nnode scripts/synthtrace simple_trace.ts --from=now-15m --to=now --clean --target=http://elastic_serverless:changeme@localhost:9200 --kibana=http://elastic_serverless:changeme@0.0.0.0:5601\r\n```\r\n- Navigate to APM > Traces, click on \"Investigate\" \r\n- if `xpack.legacy_uptime.enabled: false` in kibana.yml - \"Status\"\r\n**should** appear\r\n- if `xpack.legacy_uptime.enabled: false` in kibana.yml - \"Status\"\r\n**should not** appear\r\n- if `xpack.legacy_uptime.enabled: false` and `xpack.uptime.enabled:\r\ntrue` in kibana.yml - \"Status\" **should not** appear\r\n- if `observability:enableLegacyUptimeApp` is switched on in Advanced\r\nsettings - \"Status\" **should** appear\r\n\r\n#### Infra \r\n- Start a local kibana instance pointing to an oblt cluster\r\n- Navigate to Infrastructure, select `Kubernetes Pod` (other asset\r\ntypes, except hosts, share the same code) in `Show` dropdown\r\n- if `xpack.legacy_uptime.enabled: false` in kibana.yml - the link\r\nshould be **enabled**\r\n- if `xpack.legacy_uptime.enabled: false` in kibana.yml - the link to\r\nuptime should be **disabled**\r\n- if `xpack.legacy_uptime.enabled: false` and `xpack.uptime.enabled:\r\ntrue` in kibana.yml - the link to uptime should be **disabled**\r\n- if `observability:enableLegacyUptimeApp` is switched on in Advanced\r\nsettings - the link to uptime should be **enabled**\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"694acf7040dc56b6e2e4f37156d14a0028ff501b","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.15.0"],"title":"[Infra][APM] Fix uptime links display condition in Infra and APM","number":181425,"url":"#181425 Fix uptime links display condition in Infra and APM (#181425)\n\ncloses [#178714](#178714 Summary\r\n\r\nThis PR changes where link to legacy uptime is displayed to\r\nconditionally show it according to whether the plugin is enabled or not.\r\n\r\n<img width=\"962\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2767137/e2e659ae-bc2e-49a6-a34b-9434f04b4617\">\r\n\r\n<img width=\"962\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2767137/4aa487f5-4a61-4387-a9ed-12c9ed624410\">\r\n\r\n\r\n### How to test\r\n\r\nThe issue and the fix are the same in serverless and stateful\r\n\r\n#### APM \r\n- Run\r\n```\r\nnode scripts/synthtrace simple_trace.ts --from=now-15m --to=now --clean --target=http://elastic_serverless:changeme@localhost:9200 --kibana=http://elastic_serverless:changeme@0.0.0.0:5601\r\n```\r\n- Navigate to APM > Traces, click on \"Investigate\" \r\n- if `xpack.legacy_uptime.enabled: false` in kibana.yml - \"Status\"\r\n**should** appear\r\n- if `xpack.legacy_uptime.enabled: false` in kibana.yml - \"Status\"\r\n**should not** appear\r\n- if `xpack.legacy_uptime.enabled: false` and `xpack.uptime.enabled:\r\ntrue` in kibana.yml - \"Status\" **should not** appear\r\n- if `observability:enableLegacyUptimeApp` is switched on in Advanced\r\nsettings - \"Status\" **should** appear\r\n\r\n#### Infra \r\n- Start a local kibana instance pointing to an oblt cluster\r\n- Navigate to Infrastructure, select `Kubernetes Pod` (other asset\r\ntypes, except hosts, share the same code) in `Show` dropdown\r\n- if `xpack.legacy_uptime.enabled: false` in kibana.yml - the link\r\nshould be **enabled**\r\n- if `xpack.legacy_uptime.enabled: false` in kibana.yml - the link to\r\nuptime should be **disabled**\r\n- if `xpack.legacy_uptime.enabled: false` and `xpack.uptime.enabled:\r\ntrue` in kibana.yml - the link to uptime should be **disabled**\r\n- if `observability:enableLegacyUptimeApp` is switched on in Advanced\r\nsettings - the link to uptime should be **enabled**\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"694acf7040dc56b6e2e4f37156d14a0028ff501b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#181425 Fix uptime links display condition in Infra and APM (#181425)\n\ncloses [#178714](#178714 Summary\r\n\r\nThis PR changes where link to legacy uptime is displayed to\r\nconditionally show it according to whether the plugin is enabled or not.\r\n\r\n<img width=\"962\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2767137/e2e659ae-bc2e-49a6-a34b-9434f04b4617\">\r\n\r\n<img width=\"962\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2767137/4aa487f5-4a61-4387-a9ed-12c9ed624410\">\r\n\r\n\r\n### How to test\r\n\r\nThe issue and the fix are the same in serverless and stateful\r\n\r\n#### APM \r\n- Run\r\n```\r\nnode scripts/synthtrace simple_trace.ts --from=now-15m --to=now --clean --target=http://elastic_serverless:changeme@localhost:9200 --kibana=http://elastic_serverless:changeme@0.0.0.0:5601\r\n```\r\n- Navigate to APM > Traces, click on \"Investigate\" \r\n- if `xpack.legacy_uptime.enabled: false` in kibana.yml - \"Status\"\r\n**should** appear\r\n- if `xpack.legacy_uptime.enabled: false` in kibana.yml - \"Status\"\r\n**should not** appear\r\n- if `xpack.legacy_uptime.enabled: false` and `xpack.uptime.enabled:\r\ntrue` in kibana.yml - \"Status\" **should not** appear\r\n- if `observability:enableLegacyUptimeApp` is switched on in Advanced\r\nsettings - \"Status\" **should** appear\r\n\r\n#### Infra \r\n- Start a local kibana instance pointing to an oblt cluster\r\n- Navigate to Infrastructure, select `Kubernetes Pod` (other asset\r\ntypes, except hosts, share the same code) in `Show` dropdown\r\n- if `xpack.legacy_uptime.enabled: false` in kibana.yml - the link\r\nshould be **enabled**\r\n- if `xpack.legacy_uptime.enabled: false` in kibana.yml - the link to\r\nuptime should be **disabled**\r\n- if `xpack.legacy_uptime.enabled: false` and `xpack.uptime.enabled:\r\ntrue` in kibana.yml - the link to uptime should be **disabled**\r\n- if `observability:enableLegacyUptimeApp` is switched on in Advanced\r\nsettings - the link to uptime should be **enabled**\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"694acf7040dc56b6e2e4f37156d14a0028ff501b"}}]}] BACKPORT--> Co-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com>
- Loading branch information