Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.14] [Infra][APM] Fix uptime links display condition in Infra and APM (#181425) #181973

Merged
merged 1 commit into from
Apr 29, 2024

Commits on Apr 29, 2024

  1. [Infra][APM] Fix uptime links display condition in Infra and APM (ela…

    …stic#181425)
    
    closes [elastic#178714](elastic#178714)
    
    ## Summary
    
    This PR changes where link to legacy uptime is displayed to
    conditionally show it according to whether the plugin is enabled or not.
    
    <img width="962" alt="image"
    src="https://github.com/elastic/kibana/assets/2767137/e2e659ae-bc2e-49a6-a34b-9434f04b4617">
    
    <img width="962" alt="image"
    src="https://github.com/elastic/kibana/assets/2767137/4aa487f5-4a61-4387-a9ed-12c9ed624410">
    
    ### How to test
    
    The issue and the fix are the same in serverless and stateful
    
    #### APM
    - Run
    ```
    node scripts/synthtrace simple_trace.ts --from=now-15m --to=now --clean --target=http://elastic_serverless:changeme@localhost:9200 --kibana=http://elastic_serverless:changeme@0.0.0.0:5601
    ```
    - Navigate to APM > Traces, click on "Investigate"
    - if `xpack.legacy_uptime.enabled: false` in kibana.yml - "Status"
    **should** appear
    - if `xpack.legacy_uptime.enabled: false` in kibana.yml - "Status"
    **should not** appear
    - if `xpack.legacy_uptime.enabled: false` and `xpack.uptime.enabled:
    true` in kibana.yml - "Status" **should not** appear
    - if `observability:enableLegacyUptimeApp` is switched on in Advanced
    settings - "Status" **should** appear
    
    #### Infra
    - Start a local kibana instance pointing to an oblt cluster
    - Navigate to Infrastructure, select `Kubernetes Pod` (other asset
    types, except hosts, share the same code) in `Show` dropdown
    - if `xpack.legacy_uptime.enabled: false` in kibana.yml - the link
    should be **enabled**
    - if `xpack.legacy_uptime.enabled: false` in kibana.yml - the link to
    uptime should be **disabled**
    - if `xpack.legacy_uptime.enabled: false` and `xpack.uptime.enabled:
    true` in kibana.yml - the link to uptime should be **disabled**
    - if `observability:enableLegacyUptimeApp` is switched on in Advanced
    settings - the link to uptime should be **enabled**
    
    ---------
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    (cherry picked from commit 694acf7)
    crespocarlos committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    b742ce3 View commit details
    Browse the repository at this point in the history