Run processes in new process groups, kill process group instead of process #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some processes are getting orphaned when running Foreman with JRuby.
Creating a new pgroup allows them all to be killed together.
I believe the issue is related to how JRuby handles `Dir.chdir` by
creating a shell process: `sh -c 'cd /chdir/target; ${command}'`. That
causes a second process to be created that won't get cleaned up by
killing the parent.
|
cc @ddollar this is my only day to day pain with foreman. Would love getting this get merged. |
|
@domenkozar I think it's time to fork and release a new gem. The issue this PR addresses drives me nuts as well and it's getting close to a year for a branch with no conflicts. |
|
I maintain way too many OSS projects, but if you decide to go for it, I'm happy to test. |
|
Ping @ddollar |
This was referenced Oct 28, 2022
|
foreman forked: https://github.com/spinels/overman, https://rubygems.org/gems/overman The published version is current master (a5f9b78) + this PR. The executable is called Please try it! |
This was referenced Oct 28, 2022
|
This PR makes it better, but it's not enough, see spinels#2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #723 but rebased against master today. Credit to @davishmcclurg for suggesting those changes in the first place.
I think this change also addresses #779. It makes Foreman match what Honcho does, and Honcho does not exhibit the problem shown in #779.
Close #779
(Some additional background: There was an earlier PR #528 that did half of what this PR does, #525 was closed after that was merged, but then the PR was reverted after a few days, could not find the reason for that).