Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't follow forks? #708

Open
haydenflinner opened this issue Apr 21, 2018 · 5 comments
Open

Doesn't follow forks? #708

haydenflinner opened this issue Apr 21, 2018 · 5 comments

Comments

@haydenflinner
Copy link

I have a procfile that looks like this:

controller: ./gtcontroller
store1: sleep 1; ./gtstore -p $PORT
store2: sleep 1; ./gtstore -p $PORT
client: sleep 2; ./gtclient

When I run it with Foreman, the gtstores are still visible with pgrep store, and their pids are a little bit higher than the PIDs that Foreman claims to have seen.

When I run the same procfile with honcho, everything works fine; the processes are killed at the end as expected.

@andrewmcodes
Copy link

@haydenflinner is this still an issue?

@haydenflinner
Copy link
Author

Well, did you do anything that would have fixed it? I don't see anything in the commit history since I posted it that would have helped. Although in hindsight one workaround is

store1: bash -c "sleep 1; ./gtstore -p $PORT"

@andrewmcodes
Copy link

I’m just trying to help out the maintainer by doing some issue triage 🙂

@dentarg
Copy link

dentarg commented Oct 28, 2022

Maybe due to #779? That issue has been addressed in overman, a foreman fork, see #780 (comment)

@haydenflinner
Copy link
Author

This would probably be the perfect fix. Running in separate process group and killing that is perfect. I forgot about this tool but may need it again in the near future, I'll use your fork if so, that is the proper way to do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants