Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run processes in new process groups, kill process group instead of process #780

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Run processes in new process groups, kill process group instead of process #780

wants to merge 1 commit into from

Commits on Jun 26, 2021

  1. Run processes in new pgroup 

    Some processes are getting orphaned when running Foreman with JRuby.
Creating a new pgroup allows them all to be killed together.

I believe the issue is related to how JRuby handles `Dir.chdir` by
creating a shell process: `sh -c 'cd /chdir/target; ${command}'`. That
causes a second process to be created that won't get cleaned up by
killing the parent.
    @dentarg
    David Harsha authored and dentarg committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    a432e9d View commit details
    Browse the repository at this point in the history