Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace sys.exit with CondaBuildUserError exceptions #5255

Draft
wants to merge 38 commits into
base: 24.5.x
Choose a base branch
from
Draft

Replace sys.exit with CondaBuildUserError exceptions #5255

wants to merge 38 commits into from

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Mar 25, 2024 •
edited

Description

Resolves #4209
Resolves #5242

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 25, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 25, 2024 •
edited

CodSpeed Performance Report

Merging #5255 will not alter performance

Comparing kenodegard:remove-sys.exit (16546c8) with main (2fb469a)

Summary

✅ 3 untouched benchmarks

@kenodegard kenodegard mentioned this pull request Mar 27, 2024
Merged
3 tasks
@kenodegard
Update test_filter_files
7dee218
@kenodegard
Remove commented out code
32d508b
@kenodegard
Remove redundant error checking
ba09f05 
Check for any new files within `m.config.meta_dir` is unnecessary since they're already filtered out by `conda_build.utils.filter_files`.
@kenodegard kenodegard mentioned this pull request Mar 28, 2024
Merged
3 tasks
@jezdez jezdez mentioned this pull request Apr 29, 2024
Open
3 tasks
@kenodegard kenodegard changed the base branch from main to 24.5.x May 1, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dholth dholth dholth left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@kenodegard kenodegard

@beeankha beeankha

Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace using sys.exit with higher level error/logic handling, e.g. custom exception Remove sys.exit calls
4 participants
@kenodegard @dholth @conda-bot @beeankha