New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not create conda error reports for common / expected exceptions #5264
Open
jaimergp
wants to merge
8
commits into
conda:main
Choose a base branch
from
jaimergp:error-gracefully
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
[bot] added once the contributor has signed the CLA
label
Mar 28, 2024
jaimergp
changed the title
Error gracefully
Do not create conda error reports for common / expected exceptions
Mar 28, 2024
CodSpeed Performance ReportMerging #5264 will not alter performanceComparing Summary
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
@kenodegard @jaimergp How does this overlap with #5255? |
Mostly compatible. We need to agree on a base exception for all conda-build exceptions, or just subclass class CondaBuildUserError(CondaError):
... vs my idea:
I don't mind either, but we need to agree on one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #5263
This is what we would need to close that issue without registering new base classes in
conda
exception handler.CondaError
callssuper()
so we can't compose new exception types that inherit both fromCondaError
and e.g.CalledProcessError
. This prevents us from having a mixed exception that doesn't change which type of exception is raised (for the purpose oftry/except
idioms orisinstance
checks).I'd rather have this:
and then call:
Achieving this ^ will require changes in
conda/conda
though (either changing the CondaError class so it doesn't call super(), or having a different base class for the purpose of exception handling likeBaseCondaError
).Checklist - did you ...
news
directory (using the template) for the next release's release notes?