Add test_prefix_files
#5260
Merged
Add test_prefix_files
#5260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
kenodegard
force-pushed
the
test_prefix_files
branch
from
1497cad
to
223e8a9
Compare
CodSpeed Performance ReportMerging #5260 will not alter performanceComparing Summary
|
kenodegard
force-pushed
the
test_prefix_files
branch
from
4a9f3ff
to
e85fc20
Compare
jezdez
previously approved these changes
Apr 3, 2024
conda_build/utils.py
Outdated
Comment on lines
1789
to
1791
| def relpath(*path: str) -> str: | ||
| # this is os.path.relpath, just hacked to be faster | ||
| return join(*path).replace(prefix, "", 1).lstrip(os.path.sep) |
There was a problem hiding this comment.
Should we move the function out of prefix_files to not define on every call?
There was a problem hiding this comment.
Updated the algorithm slightly and eliminated the need for the helper function entirely, see 89e2edc
It's even faster now! ⚡
---------------------------------------------------------------------------------- benchmark: 4 tests -----------------------------------------------------------------------------------
Name (time in ms) Min Max Mean StdDev Median IQR Outliers OPS Rounds Iterations
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_slicing 38.0992 (1.0) 48.0364 (1.0) 41.1855 (1.0) 3.0405 (3.63) 39.9373 (1.0) 3.2863 (3.47) 8;3 24.2804 (1.0) 26 1
test_fast_relpath 41.9621 (1.10) 49.4438 (1.03) 44.7707 (1.09) 2.4972 (2.99) 45.0585 (1.13) 4.9830 (5.26) 10;0 22.3361 (0.92) 21 1
test_relpath 84.3830 (2.21) 87.2163 (1.82) 85.4201 (2.07) 0.8365 (1.0) 85.3213 (2.14) 0.9473 (1.0) 5;1 11.7068 (0.48) 12 1
test_pathlib 400.0558 (10.50) 418.3695 (8.71) 408.1218 (9.91) 6.7014 (8.01) 407.1493 (10.19) 7.5565 (7.98) 2;0 2.4502 (0.10) 5 1
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
beeankha
approved these changes
Apr 18, 2024
jezdez
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on #5255 found that
conda_build.utils.prefix_filesmakes an unnecessary call toexpand_globs. We only callexpand_globsfor symlink directories andexpand_globsreturns the path as is for symlinks.Checklist - did you ...
Add a file to thenewsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?