Fix/ sort by categorical variables #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asc was sorted in desc and vice versa. this fixes those so they are sorted in the correct direction
was not the cause of the bug
buckhalt
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users have been able to configure rules for sorting by categorical variables in Architect, but they were being sorted as strings. This PR fixes sorting functionality for categorical variables to actually sort by the values provided.
The hierarchy for sorting is determined by the order that the values are defined in the variable definition. This user-supplied hierarchy is assumed to be high to low, to maintain consistency with the hierarchy sort used currently for sorting by ordinal variables.
In cases of items having multiple values in a category array, presence of a category is ranked higher than absence of. For instance [“A”, “B”] is considered higher in the hierarchy than [“A”].