Release/6.5.3 #1267
Merged
Release/6.5.3 #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asc was sorted in desc and vice versa. this fixes those so they are sorted in the correct direction
was not the cause of the bug
Fix/ sort by categorical variables
jthrilly
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
We discussed a more complex version of this fix that didn't 'pollute' the concept of hierarchical sorting, but in the end decided that time was better spent elsewhere.
If we return to this issue, we can think again about how multiple categorical values per entity can/should be sorted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release branch for 6.5.3
Changelog: