Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor benchmarks' tests #32

Closed
wants to merge 32 commits into from
Closed

Conversation

sfmig
Copy link
Contributor

@sfmig sfmig commented Dec 8, 2023

Before submitting a pull request (PR), please read the contributing guide.

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

What does this PR do?

References

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Is this a breaking change?

If this PR breaks any existing functionality, please explain how and why.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (ffee651) 82.75% compared to head (1fcb6f2) 82.23%.
Report is 1 commits behind head on main.

Files Patch % Lines
benchmarks/cellfinder_core.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   82.75%   82.23%   -0.53%     
==========================================
  Files          27       26       -1     
  Lines        1577     1452     -125     
==========================================
- Hits         1305     1194     -111     
+ Misses        272      258      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig
Copy link
Contributor Author

sfmig commented Apr 30, 2024

deprecated in favour of #96

@sfmig sfmig closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant