Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed modcods not in Table 5 and 12 #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

removed modcods not in Table 5 and 12 #13

wants to merge 1 commit into from

Conversation

Abraxas3d
Copy link
Member

Greetings all!
Modcods not in Table 5 and Table 12 have been removed from the cfg creation case statements. Here are the specifics.

  1. Short frames do not use the 9/10 rate, so that rate was removed for all short frame entries.
  2. 8PSK uses 6 of the 11 rates. Unused rates were removed from both short and normal frame entries.
  3. 16APSK uses 6 of the 11 rates. Unused rates were removed from both short and normal frame entries.
  4. 32APSK uses 5 of the 11 rates. Unused rates were removed from both short and normal frame entries.

@Abraxas3d
removed modcods not in Table 5 and 12
f11bfec 
Modcods not in Table 5 and Table 12 have been removed from the cfg creation case statements. Here are the specifics.
1) Short frames do not use the 9/10 rate, so that rate was removed for all short frame entries.
2) 8PSK uses 6 of the 11 rates. Unused rates were removed from both short and normal frame entries.
3) 16APSK uses 6 of the 11 rates. Unused rates were removed from both short and normal frame entries.
4) 32APSK uses 5 of the 11 rates. Unused rates were removed from both short and normal frame entries.
@Abraxas3d Abraxas3d added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 21, 2022
@Abraxas3d Abraxas3d self-assigned this Oct 21, 2022
@Abraxas3d Abraxas3d linked an issue Oct 21, 2022 that may be closed by this pull request
correct modcods and frame types #12
Open
MustBeArt
MustBeArt reviewed Oct 21, 2022
View reviewed changes
Copy link

@MustBeArt MustBeArt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all these changes are right.

Maybe we should do something more hardware-friendly in the case where an unknown mode word is received. Default to a valid MODCOD instead of failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MustBeArt MustBeArt MustBeArt left review comments

@suoto suoto Awaiting requested review from suoto

At least 1 approving review is required to merge this pull request.

Assignees

@Abraxas3d Abraxas3d

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

correct modcods and frame types
2 participants
@Abraxas3d @MustBeArt