Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct modcods and frame types #12

Open
Abraxas3d opened this issue Oct 17, 2022 · 0 comments · May be fixed by #13
Open

correct modcods and frame types #12

Abraxas3d opened this issue Oct 17, 2022 · 0 comments · May be fixed by #13
Assignees
@Abraxas3d
Labels
documentation Improvements or additions to documentation invalid This doesn't seem right

Comments

@Abraxas3d
Copy link
Member

There are some modulation and encoding pairs, and some code rates and frame length pairs, that don't exist in DVB-S2, so these should probably be removed from the case statement that assigns enumerated types to cfg. I can write a pull request for this.
@Abraxas3d Abraxas3d added documentation Improvements or additions to documentation invalid This doesn't seem right labels Oct 17, 2022
@Abraxas3d Abraxas3d self-assigned this Oct 17, 2022
@Abraxas3d Abraxas3d linked a pull request Oct 21, 2022 that will close this issue
removed modcods not in Table 5 and 12 #13
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abraxas3d Abraxas3d

Labels
documentation Improvements or additions to documentation invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed modcods not in Table 5 and 12 OpenResearchInstitute/dvb_fpga
1 participant
@Abraxas3d