Idea for a patch on ppemax calculations until 244 #1195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affie
force-pushed
the
hackfix/21Q1/ppemax
branch
from
2830437
to
74128f5
Compare
Codecov Report
@@ Coverage Diff @@
## master #1195 +/- ##
==========================================
+ Coverage 71.03% 71.13% +0.09%
==========================================
Files 55 55
Lines 4337 4351 +14
==========================================
+ Hits 3081 3095 +14
Misses 1256 1256
Continue to review full report at Codecov.
|
|
I was waiting for local RoME tests to complete, it fails on what looks like an unrelated test. |
|
Lets take a moment to be sure where the issues are to do best workaround until the new |
|
REplaced by #1209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1185