New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow-bot: update comment.yml: add support for NotReadyForARMReview
and simplify the file
#28877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konrad-jamrozik
added
Central-EngSys
This item is owned by the Azure SDK Engineering System team.
Spec PR Tools
Tooling that runs in azure-rest-api-specs repo.
labels
Apr 26, 2024
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
Swagger Generation Artifacts
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
konrad-jamrozik
changed the title
Update comment.yml: add support for
workflow-bot: update comment.yml: add support for Apr 26, 2024
NotReadyForARMReview
and simplify the fileNotReadyForARMReview
and simplify the file
mikeharder
approved these changes
Apr 26, 2024
konrad-jamrozik
added a commit
to test-repo-billy/azure-rest-api-specs
that referenced
this pull request
Apr 29, 2024
konrad-jamrozik
added a commit
to test-repo-billy/azure-rest-api-specs
that referenced
this pull request
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Central-EngSys
This item is owned by the Azure SDK Engineering System team.
Spec PR Tools
Tooling that runs in azure-rest-api-specs repo.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to implementation of:
ARMChangesRequested
label should be replaced withNotReadyForARMReview
when appropriate. azure-sdk-tools#6624Companion change:
I removed most rules from the
comment.yml
because I converted them to "required label rules" inopenapi-alps
in the companion PR.