Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow-bot: update comment.yml: add support for NotReadyForARMReview and simplify the file #28877

Merged
merged 3 commits into from Apr 30, 2024

Conversation

konrad-jamrozik
Copy link
Member

@konrad-jamrozik konrad-jamrozik commented Apr 26, 2024

Contributes to implementation of:

Companion change:

  • Pull Request 547143: Add "NotReadyForArmReview" label handling; fix "RPaasException" label handling; rework requiredLabelsRules

I removed most rules from the comment.yml because I converted them to "required label rules" in openapi-alps in the companion PR.

@konrad-jamrozik konrad-jamrozik added Central-EngSys This item is owned by the Azure SDK Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. labels Apr 26, 2024
@konrad-jamrozik konrad-jamrozik self-assigned this Apr 26, 2024
Copy link

openapi-pipeline-app bot commented Apr 26, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Apr 26, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Apr 26, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Apr 26, 2024

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@konrad-jamrozik konrad-jamrozik changed the title Update comment.yml: add support for NotReadyForARMReview and simplify the file workflow-bot: update comment.yml: add support for NotReadyForARMReview and simplify the file Apr 26, 2024
@konrad-jamrozik konrad-jamrozik merged commit 874c4f1 into main Apr 30, 2024
32 checks passed
@konrad-jamrozik konrad-jamrozik deleted the konrad-jamrozik-patch-1 branch April 30, 2024 21:17
@konrad-jamrozik
Copy link
Member Author

Announcement on Teams

konrad-jamrozik added a commit to test-repo-billy/azure-rest-api-specs that referenced this pull request May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This item is owned by the Azure SDK Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants