Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR Workflow] The ARMChangesRequested label should be replaced with NotReadyForARMReview when appropriate. #6624

Closed
konrad-jamrozik opened this issue Jul 31, 2023 · 3 comments
Closed

[PR Workflow] The ARMChangesRequested label should be replaced with NotReadyForARMReview when appropriate. #6624

konrad-jamrozik opened this issue Jul 31, 2023 · 3 comments
Assignees
@konrad-jamrozik
Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@konrad-jamrozik
Copy link
Member

Currently we are using ARMChangesRequested label to denote two things.

  1. when the ARM reviewer actually requested changes.
  2. when the PR is not yet ready for ARM review.

Code here. Basically, the label ARMChangesRequested is added to denote "this PR is not yet ready for ARM to look at it". And it is not yet ready because it has unfixed breaking changes issues. Perhaps we could make it clearer by introducing a new label like NotReadyForARMReview.
@konrad-jamrozik konrad-jamrozik added Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. labels Jul 31, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Jul 31, 2023
@konrad-jamrozik konrad-jamrozik mentioned this issue Jul 31, 2023
Closed
@konrad-jamrozik
Copy link
Member Author

Remark from @rkmanda:

This makes sense and I am fine with it. We can weigh adding the new label against not having any of the ARMChangesRequested or NotReadyForARMReview labels at all.

@konrad-jamrozik konrad-jamrozik mentioned this issue Aug 5, 2023
Closed
@konrad-jamrozik konrad-jamrozik mentioned this issue Apr 26, 2024
Closed
3 tasks
@konrad-jamrozik
Copy link
Member Author

konrad-jamrozik commented Apr 26, 2024 •
edited

@konrad-jamrozik konrad-jamrozik mentioned this issue Apr 26, 2024
Merged
@konrad-jamrozik
Copy link
Member Author

konrad-jamrozik commented Apr 30, 2024 •
edited

Announcement on Teams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Azure SDK EngSys 🐬🛥️☀️😎
Archived in project
Spec PR Tools
Status: 🎊 Closed
Milestone
No milestone
Development

No branches or pull requests
1 participant
@konrad-jamrozik