Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow-bot: update comment.yml: add support for NotReadyForARMReview and simplify the file #28877

Merged
merged 3 commits into from
Apr 30, 2024
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
77 changes: 0 additions & 77 deletions .github/comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,6 @@
If you want to publish the PR to the public repo (`Azure/azure-rest-api-specs`) `main` branch,
see [aka.ms/azsdk/move-pr](https://aka.ms/azsdk/move-pr).

- rule:
type: label
label: CI-NewRPNamespaceWithoutRPaaS
onLabeledComments: "Hi @${PRAuthor} This PR was flagged for introducing a new RP namespace that is not being onboarded with [RPaaS](https://armwiki.azurewebsites.net/rpaas/overview.html). Label: `CI-NewRPNamespaceWithoutRPaaS`. Merging this PR to the main branch will be blocked as RPaaS is required for new RPs. To resolve this and allow the PR to be merged into the main branch, please [use RPaaS to onboard the new RP](https://armwiki.azurewebsites.net/rpaas/gettingstarted.html). Otherwise, please see [aka.ms/RPaaSException](https://aka.ms/RPaaSException) to discuss an exception."

- rule:
type: label
label: CI-RpaaSRPNotInPrivateRepo
onLabeledComments: "Hi @${PRAuthor} This PR was flagged for attempting to introduce a new RP namespace to the main branch without first merging the new RP to the RPSaaSMaster branch. Label: `CI-RpaaSRPNotInPrivateRepo`. Please add the new RP in a merge to RPSaaSMaster before continuing the merge to main."

- rule:
type: label
label: ArcReview
Expand All @@ -33,75 +23,8 @@
label: new-rp-namespace
onLabeledComments: "Hi, @${PRAuthor}, our workflow has detected that there is no management SDK ever released for your RP, to further process SDK onboard for your RP, you should have the SDK client library name of your RP reviewed and approved. </br> <b>Action Required</b>: <li> Follow this guidance [Naming for new initial management or client libraries (new SDKs) - Overview (azure.com)](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/821/Naming-for-new-initial-management-or-client-libraries-(new-SDKs)) to create an issue for management client library name arch board review. </li> <li>Paste the issue link that you created in step 1 in this PR</li> </br> <b> Impact</b>: SDK release owner will take the approved management client library name to release SDK. No client library name approval will leads to SDK release delayed."

- rule:
type: checkbox
keywords:
- "Update existing version to fix swagger quality issues in S360"
onCheckedLabels:
- FixS360

- rule:
type: label
label: ARMReview
booleanFilterExpression: "!(ARMSignedOff||ARMChangesRequested||Approved-OkToMerge)"
onLabeledAddLabels:
- WaitForARMFeedback

- rule:
type: label
label: WaitForARMFeedback
onLabeledRemoveLabels:
- ARMChangesRequested
- ARMSignedOff

- rule:
type: label
label: ARMSignedOff
onLabeledRemoveLabels:
- WaitForARMFeedback
- ARMChangesRequested

- rule:
type: label
label: ARMChangesRequested
onLabeledComments: >-
This PR has `ARMChangesRequested` label. Please address or respond to feedback from the ARM API reviewer. <br/>
When you are ready to continue the ARM API review, please remove the `ARMChangesRequested` label. <br/>
Learn more at [aka.ms/azsdk/pr-arm-review](https://aka.ms/azsdk/pr-arm-review).
onLabeledRemoveLabels:
- WaitForARMFeedback

- rule:
type: label
label: Approved-BreakingChange
booleanFilterExpression: "!(ARMSignedOff||WaitForARMFeedback||ARMChangesRequested||Approved-OkToMerge||WaitForARMRevisit)&&ARMReview"
onLabeledAddLabels:
- WaitForARMFeedback

- rule:
type: label
label: BreakingChange-Approved-*
booleanFilterExpression: "!(ARMSignedOff||WaitForARMFeedback||ARMChangesRequested||Approved-OkToMerge||WaitForARMRevisit)&&ARMReview"
onLabeledAddLabels:
- WaitForARMFeedback

- rule:
type: label
label: Versioning-Approved-*
booleanFilterExpression: "!(ARMSignedOff||WaitForARMFeedback||ARMChangesRequested||Approved-OkToMerge||WaitForARMRevisit)&&ARMReview"
onLabeledAddLabels:
- WaitForARMFeedback

- rule:
type: unlabeled
label: ARMChangesRequested
booleanFilterExpression: "!(CI-NewRPNamespaceWithoutRPaaS||CI-RpaaSRPNotInPrivateRepo)"
onUnlabeledAddLabels:
- WaitForARMFeedback

- rule:
type: unlabeled
label: ARMChangesRequested
booleanFilterExpression: "CI-NewRPNamespaceWithoutRPaaS||CI-RpaaSRPNotInPrivateRepo"
onUnlabeledAddLabels:
- ARMChangesRequested