Zone design loads #1705

shorowit · 2024-05-02T18:21:42Z

Pull Request Description

Calculate block design loads at the HPXML Zone level. If no HPXML Zone elements are present, the entire building is treated as a single zone (like before).

TODO:

Finalize infiltration/ventilation
Decide on duct loads for HPs w/ standalone backup systems
Update output files
How to handle homes with, e.g., no cooling system or a partial cooling system?
Can we use more robust AttachedToSpace checks? See Schematron doc
Finalize internal gains
Update input/output documentation

Checklist

PR Author: Check these when they're done. Not all may apply. ~~strikethrough~~ and check any that do not apply.

PR Reviewer: Verify each has been completed.

Schematron validator (EPvalidator.xml) has been updated
Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
Documentation has been updated
Changelog has been updated
openstudio tasks.rb update_measures has been run
No unexpected changes to simulation results of sample files

…es are present, the entire building is treated as a single zone.

…rather than the HVACPlant element. Huge refactor & cleanup of variable names. Address duct loads for dual-fuel HPs. Add error-checking for HVAC systems attached to unconditioned zones.

…o-HPXML into zone_design_loads

…using Skylight/AttachedToFloor elements for skylights with shafts.

shorowit · 2024-05-06T20:02:00Z

Action items per our discussion today:

Document when AttachedToZone/AttachedToSpace are required
Add error-checking for surfaces w/ AttachedToSpace that are attached to an unconditioned space; add validation test
Add validation tests where sum(Space) != Building for #Occupants and Sensible/Latent Internal Gains
Create GitHub issue around need for more flexibility where cooling system and heating system do not serve the same zone (same set of spaces) Add flexibility for system-level design loads #1706
Investigate diffs w/ parent PR
Create new PR to better handle ventilation -- issue created at Improve MJ8 infiltration/ventilation #1711
Create HPXML test file w/ multiple conditioned zones; add unit tests

cc @yzhou601 @jonwinkler

…dio-HPXML into zone_design_loads # Conflicts: # BuildResidentialHPXML/measure.rb # BuildResidentialHPXML/measure.xml # HPXMLtoOpenStudio/measure.xml # HPXMLtoOpenStudio/resources/hvac_sizing.rb # workflow/tests/base_results/results_simulations_energy.csv # workflow/tests/base_results/results_simulations_loads.csv # workflow/tests/base_results/results_simulations_misc.csv

…o-HPXML into zone_design_loads

…dio-HPXML into zone_design_loads

shorowit · 2024-05-15T03:35:18Z

workflow/tests/base_results/results_simulations_hvac.csv

-base-enclosure-infil-ela.xml,6.8,91.76,36000.0,24000.0,0.0,37830.0,8798.0,7508.0,0.0,575.0,6840.0,0.0,0.0,2148.0,2171.0,9790.0,0.0,20619.0,6126.0,7037.0,0.0,207.0,321.0,0.0,0.0,0.0,2293.0,1314.0,0.0,3320.0,0.0,0.0,0.0,0.0,0.0,0.0
+base-enclosure-infil-ela.xml,6.8,91.76,36000.0,24000.0,0.0,37830.0,8798.0,7508.0,0.0,575.0,6840.0,0.0,0.0,2148.0,2171.0,9790.0,0.0,20565.0,6072.0,7037.0,0.0,207.0,321.0,0.0,0.0,0.0,2293.0,1314.0,0.0,3320.0,0.0,-591.0,0.0,-1391.0,0.0,800.0


Note that some of these diffs are because we used to prevent a negative value for latent cooling loads. It's been this way since the initial implementation of MJ8. But I have confirmed with another ACCA accredited software tool that negative values are fine; you can report a negative latent cooling load and the total cooling load can indeed be lowered by a negative latent cooling load.

…inor cleanup.

…o-HPXML into zone_design_loads

…x house045 skylight.

…diffs expected.

yzhou601

I haven't run any simulation yet, just reviewing codes and trying to understand the changes. Glad to see much refactoring happening here. Overall they look pretty good. Thorough tests around them. I'm going to approve first, probably will be able to test more during room by room branch review.

HPXMLtoOpenStudio/resources/hpxml.rb

HPXMLtoOpenStudio/resources/hpxml_defaults.rb

HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml

HPXMLtoOpenStudio/resources/hvac_sizing.rb

HPXMLtoOpenStudio/tests/test_hvac_sizing.rb

…o-HPXML into hpxml_subsurface_attrs

…o-HPXML into hpxml_subsurface_attrs # Conflicts: # HPXMLtoOpenStudio/measure.xml [ci skip]

yzhou601 · 2024-05-15T22:24:27Z

Latest changes look good to me, everything looks good, for the only remaining question about fenestration procedure, I don't think it's necessary to answer it before merging. I'm fine going with what it is now and we can discuss it later.

Misc hpxml.rb cleanup

shorowit added 2 commits May 1, 2024 15:18

Initial progress.

e434cf4

Calculate block design loads at the HPXML Zone level. If no HPXML Zon…

af06dc6

…es are present, the entire building is treated as a single zone.

shorowit added the enhancement New feature or request label May 2, 2024

shorowit self-assigned this May 2, 2024

shorowit and others added 13 commits May 2, 2024 12:31

Bugfix.

0b26d0d

Another bugfix.

1a6e423

Another pass.

b62a3bd

Latest results.

ac4500a

Update outputs; design loads now created on each in.xml Zone element …

587fdea

…rather than the HVACPlant element. Huge refactor & cleanup of variable names. Address duct loads for dual-fuel HPs. Add error-checking for HVAC systems attached to unconditioned zones.

Merge branch 'zone_design_loads' of https://github.com/NREL/OpenStudi…

b4f98d1

…o-HPXML into zone_design_loads

Simplify code. Address buildings without cooling/heating.

b8c9f8a

More robust logic for AttachedToSpace/AttachedToZone elements. Start …

cca9076

…using Skylight/AttachedToFloor elements for skylights with shafts.

Fix CI failure.

91f97a3

Need to exclude HVAC Zone Design Load too.

52294e6

Latest results.

fcaedce

Small changes. [ci skip]

a7e7bfc

Update docs, etc.

b2fd3f5

shorowit added 2 commits May 6, 2024 14:50

Document AttachedToSpace/AttachedToZone.

983f695

Update error checking and add validation tests.

e243895

shorowit mentioned this pull request May 6, 2024

Add flexibility for system-level design loads #1706

Open

shorowit and others added 9 commits May 6, 2024 18:38

Address regressions for e.g. partial HVAC systems.

4a2e930

Latest results.

897cef4

Update changelog [ci skip]

048d93b

Merge branch 'zone_design_loads' of https://github.com/NREL/OpenStudi…

192034b

…o-HPXML into zone_design_loads

Bugfixes.

4eef071

Merge branch 'room-by-room-sizing' of https://github.com/NREL/OpenStu…

6ba7944

…dio-HPXML into zone_design_loads

Merge branch 'room-by-room-sizing' of https://github.com/NREL/OpenStu…

e17fa5c

…dio-HPXML into zone_design_loads

Latest results.

371eb7d

Merge branch 'room-by-room-sizing' of https://github.com/NREL/OpenStu…

97dec98

…dio-HPXML into zone_design_loads

shorowit mentioned this pull request May 14, 2024

Improve MJ8 infiltration/ventilation #1711

Closed

5 tasks

shorowit and others added 2 commits May 14, 2024 19:29

Add sample file and unit tests. Fix zone AED curves.

c2de286

Latest results.

3f446f8

shorowit marked this pull request as ready for review May 15, 2024 03:24

shorowit requested a review from yzhou601 May 15, 2024 03:28

shorowit commented May 15, 2024

View reviewed changes

shorowit and others added 9 commits May 15, 2024 11:54

Revert change to WAR; should be gross wall area, not net wall area. M…

0b3df9b

…inor cleanup.

Merge branch 'zone_design_loads' of https://github.com/NREL/OpenStudi…

dfbeb5f

…o-HPXML into zone_design_loads

Fixed duct load apportioning.

21cb116

Latest results.

c4d0228

minor cleanup for window, no diff expected

161f2ef

Add a warning if a skylight is not connected to conditioned space. Fi…

3f3c2a8

…x house045 skylight.

Rename attributes to be more consistent w/ HPXML. Minor refactor. No …

9d3237a

…diffs expected.

Bugfix.

a2d89a2

Latest results.

c54e7d9

yzhou601 approved these changes May 15, 2024

View reviewed changes

shorowit added 5 commits May 15, 2024 15:28

Merge branch 'zone_design_loads' of https://github.com/NREL/OpenStudi…

c70466f

…o-HPXML into hpxml_subsurface_attrs

Oops, missed these two.

c00e1b7

Address review comments.

a7798ec

I like this better.

90bddbf

Merge branch 'zone_design_loads' of https://github.com/NREL/OpenStudi…

1470350

…o-HPXML into hpxml_subsurface_attrs # Conflicts: # HPXMLtoOpenStudio/measure.xml [ci skip]

Merge pull request #1713 from NREL/hpxml_subsurface_attrs

1206d19

Misc hpxml.rb cleanup

shorowit merged commit 32f5187 into room-by-room-sizing May 15, 2024
7 checks passed

shorowit deleted the zone_design_loads branch May 15, 2024 23:05

joseph-robertson mentioned this pull request May 16, 2024

Latest OS-HPXML NREL/resstock#1240

Merged

16 tasks

shorowit mentioned this pull request May 16, 2024

Skylight bugfix #1718

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Zone design loads #1705

Zone design loads #1705

shorowit commented May 2, 2024 •

edited

shorowit commented May 6, 2024 •

edited

shorowit May 15, 2024

yzhou601 left a comment

yzhou601 commented May 15, 2024

		base-enclosure-infil-ela.xml,6.8,91.76,36000.0,24000.0,0.0,37830.0,8798.0,7508.0,0.0,575.0,6840.0,0.0,0.0,2148.0,2171.0,9790.0,0.0,20619.0,6126.0,7037.0,0.0,207.0,321.0,0.0,0.0,0.0,2293.0,1314.0,0.0,3320.0,0.0,0.0,0.0,0.0,0.0,0.0
		base-enclosure-infil-ela.xml,6.8,91.76,36000.0,24000.0,0.0,37830.0,8798.0,7508.0,0.0,575.0,6840.0,0.0,0.0,2148.0,2171.0,9790.0,0.0,20565.0,6072.0,7037.0,0.0,207.0,321.0,0.0,0.0,0.0,2293.0,1314.0,0.0,3320.0,0.0,-591.0,0.0,-1391.0,0.0,800.0

Zone design loads #1705

Zone design loads #1705

Conversation

shorowit commented May 2, 2024 • edited

Pull Request Description

Checklist

shorowit commented May 6, 2024 • edited

shorowit May 15, 2024

Choose a reason for hiding this comment

yzhou601 left a comment

Choose a reason for hiding this comment

yzhou601 commented May 15, 2024

shorowit commented May 2, 2024 •

edited

shorowit commented May 6, 2024 •

edited