Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zone design loads #1705

Merged
merged 44 commits into from
May 15, 2024
Merged

Zone design loads #1705

merged 44 commits into from
May 15, 2024

Commits on May 1, 2024

  1. Initial progress.

    @shorowit
    shorowit committed May 1, 2024
    Configuration menu
    Copy the full SHA
    e434cf4 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Calculate block design loads at the HPXML Zone level. If no HPXML Zon… 

    …es are present, the entire building is treated as a single zone.
    @shorowit
    shorowit committed May 2, 2024
    Configuration menu
    Copy the full SHA
    af06dc6 View commit details
    Browse the repository at this point in the history

  2. Bugfix.

    @shorowit
    shorowit committed May 2, 2024
    Configuration menu
    Copy the full SHA
    0b26d0d View commit details
    Browse the repository at this point in the history

  3. Another bugfix.

    @shorowit
    shorowit committed May 2, 2024
    Configuration menu
    Copy the full SHA
    1a6e423 View commit details
    Browse the repository at this point in the history

  4. Another pass.

    @shorowit
    shorowit committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b62a3bd View commit details
    Browse the repository at this point in the history

  5. Latest results.

    GitHub Action committed May 2, 2024
    Configuration menu
    Copy the full SHA
    ac4500a View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Update outputs; design loads now created on each in.xml Zone element … 

    …rather than the HVACPlant element. Huge refactor & cleanup of variable names. Address duct loads for dual-fuel HPs. Add error-checking for HVAC systems attached to unconditioned zones.
    @shorowit
    shorowit committed May 3, 2024
    Configuration menu
    Copy the full SHA
    587fdea View commit details
    Browse the repository at this point in the history

  2. Merge branch 'zone_design_loads' of https://github.com/NREL/OpenStudi… 

    …o-HPXML into zone_design_loads
    @shorowit
    shorowit committed May 3, 2024
    Configuration menu
    Copy the full SHA
    b4f98d1 View commit details
    Browse the repository at this point in the history

  3. Simplify code. Address buildings without cooling/heating.

    @shorowit
    shorowit committed May 3, 2024
    Configuration menu
    Copy the full SHA
    b8c9f8a View commit details
    Browse the repository at this point in the history

  4. More robust logic for AttachedToSpace/AttachedToZone elements. Start … 

    …using Skylight/AttachedToFloor elements for skylights with shafts.
    @shorowit
    shorowit committed May 3, 2024
    Configuration menu
    Copy the full SHA
    cca9076 View commit details
    Browse the repository at this point in the history

  5. Fix CI failure.

    @shorowit
    shorowit committed May 3, 2024
    Configuration menu
    Copy the full SHA
    91f97a3 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2024

  1. Need to exclude HVAC Zone Design Load too.

    @shorowit
    shorowit committed May 4, 2024
    Configuration menu
    Copy the full SHA
    52294e6 View commit details
    Browse the repository at this point in the history

  2. Latest results.

    GitHub Action committed May 4, 2024
    Configuration menu
    Copy the full SHA
    fcaedce View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Small changes. [ci skip]

    @shorowit
    shorowit committed May 6, 2024
    Configuration menu
    Copy the full SHA
    a7e7bfc View commit details
    Browse the repository at this point in the history

  2. Update docs, etc.

    @shorowit
    shorowit committed May 6, 2024
    Configuration menu
    Copy the full SHA
    b2fd3f5 View commit details
    Browse the repository at this point in the history

  3. Document AttachedToSpace/AttachedToZone.

    @shorowit
    shorowit committed May 6, 2024
    Configuration menu
    Copy the full SHA
    983f695 View commit details
    Browse the repository at this point in the history

  4. Update error checking and add validation tests.

    @shorowit
    shorowit committed May 6, 2024
    Configuration menu
    Copy the full SHA
    e243895 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Address regressions for e.g. partial HVAC systems.

    @shorowit
    shorowit committed May 7, 2024
    Configuration menu
    Copy the full SHA
    4a2e930 View commit details
    Browse the repository at this point in the history

  2. Latest results.

    GitHub Action committed May 7, 2024
    Configuration menu
    Copy the full SHA
    897cef4 View commit details
    Browse the repository at this point in the history

  3. Update changelog [ci skip]

    @shorowit
    shorowit committed May 7, 2024
    Configuration menu
    Copy the full SHA
    048d93b View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Merge branch 'room-by-room-sizing' of https://github.com/NREL/OpenStu… 

    …dio-HPXML into zone_design_loads

# Conflicts:
#	BuildResidentialHPXML/measure.rb
#	BuildResidentialHPXML/measure.xml
#	HPXMLtoOpenStudio/measure.xml
#	HPXMLtoOpenStudio/resources/hvac_sizing.rb
#	workflow/tests/base_results/results_simulations_energy.csv
#	workflow/tests/base_results/results_simulations_loads.csv
#	workflow/tests/base_results/results_simulations_misc.csv
    @shorowit
    shorowit committed May 9, 2024
    Configuration menu
    Copy the full SHA
    8a05f4b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'zone_design_loads' of https://github.com/NREL/OpenStudi… 

    …o-HPXML into zone_design_loads
    @shorowit
    shorowit committed May 9, 2024
    Configuration menu
    Copy the full SHA
    192034b View commit details
    Browse the repository at this point in the history

  3. Bugfixes.

    @shorowit
    shorowit committed May 9, 2024
    Configuration menu
    Copy the full SHA
    4eef071 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'room-by-room-sizing' of https://github.com/NREL/OpenStu… 

    …dio-HPXML into zone_design_loads
    @shorowit
    shorowit committed May 9, 2024
    Configuration menu
    Copy the full SHA
    6ba7944 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Merge branch 'room-by-room-sizing' of https://github.com/NREL/OpenStu… 

    …dio-HPXML into zone_design_loads
    @yzhou601
    yzhou601 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    e17fa5c View commit details
    Browse the repository at this point in the history

  2. Latest results.

    GitHub Action committed May 14, 2024
    Configuration menu
    Copy the full SHA
    371eb7d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'room-by-room-sizing' of https://github.com/NREL/OpenStu… 

    …dio-HPXML into zone_design_loads
    @shorowit
    shorowit committed May 14, 2024
    Configuration menu
    Copy the full SHA
    97dec98 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Add sample file and unit tests. Fix zone AED curves.

    @shorowit
    shorowit committed May 15, 2024
    Configuration menu
    Copy the full SHA
    c2de286 View commit details
    Browse the repository at this point in the history

  2. Latest results.

    GitHub Action committed May 15, 2024
    Configuration menu
    Copy the full SHA
    3f446f8 View commit details
    Browse the repository at this point in the history

  3. Revert change to WAR; should be gross wall area, not net wall area. M… 

    …inor cleanup.
    @shorowit
    shorowit committed May 15, 2024
    Configuration menu
    Copy the full SHA
    0b3df9b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'zone_design_loads' of https://github.com/NREL/OpenStudi… 

    …o-HPXML into zone_design_loads
    @shorowit
    shorowit committed May 15, 2024
    Configuration menu
    Copy the full SHA
    dfbeb5f View commit details
    Browse the repository at this point in the history

  5. Fixed duct load apportioning.

    @shorowit
    shorowit committed May 15, 2024
    Configuration menu
    Copy the full SHA
    21cb116 View commit details
    Browse the repository at this point in the history

  6. Latest results.

    GitHub Action committed May 15, 2024
    Configuration menu
    Copy the full SHA
    c4d0228 View commit details
    Browse the repository at this point in the history

  7. minor cleanup for window, no diff expected

    @yzhou601
    yzhou601 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    161f2ef View commit details
    Browse the repository at this point in the history

  8. Add a warning if a skylight is not connected to conditioned space. Fi… 

    …x house045 skylight.
    @shorowit
    shorowit committed May 15, 2024
    Configuration menu
    Copy the full SHA
    3f3c2a8 View commit details
    Browse the repository at this point in the history

  9. Rename attributes to be more consistent w/ HPXML. Minor refactor. No … 

    …diffs expected.
    @shorowit
    shorowit committed May 15, 2024
    Configuration menu
    Copy the full SHA
    9d3237a View commit details
    Browse the repository at this point in the history

  10. Bugfix.

    @shorowit
    shorowit committed May 15, 2024
    Configuration menu
    Copy the full SHA
    a2d89a2 View commit details
    Browse the repository at this point in the history

  11. Latest results.

    GitHub Action committed May 15, 2024
    Configuration menu
    Copy the full SHA
    c54e7d9 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'zone_design_loads' of https://github.com/NREL/OpenStudi… 

    …o-HPXML into hpxml_subsurface_attrs
    @shorowit
    shorowit committed May 15, 2024
    Configuration menu
    Copy the full SHA
    c70466f View commit details
    Browse the repository at this point in the history

  13. Oops, missed these two.

    @shorowit
    shorowit committed May 15, 2024
    Configuration menu
    Copy the full SHA
    c00e1b7 View commit details
    Browse the repository at this point in the history

  14. Address review comments.

    @shorowit
    shorowit committed May 15, 2024
    Configuration menu
    Copy the full SHA
    a7798ec View commit details
    Browse the repository at this point in the history

  15. I like this better.

    @shorowit
    shorowit committed May 15, 2024
    Configuration menu
    Copy the full SHA
    90bddbf View commit details
    Browse the repository at this point in the history

  16. Merge branch 'zone_design_loads' of https://github.com/NREL/OpenStudi… 

    …o-HPXML into hpxml_subsurface_attrs

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml

[ci skip]
    @shorowit
    shorowit committed May 15, 2024
    Configuration menu
    Copy the full SHA
    1470350 View commit details
    Browse the repository at this point in the history

  17. Merge pull request #1713 from NREL/hpxml_subsurface_attrs 

    Misc hpxml.rb cleanup
    @shorowit
    shorowit committed May 15, 2024
    Configuration menu
    Copy the full SHA
    1206d19 View commit details
    Browse the repository at this point in the history