Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skylight bugfix #1718

Merged
merged 7 commits into from
May 17, 2024
Merged

Skylight bugfix #1718

merged 7 commits into from
May 17, 2024

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented May 16, 2024 •
edited

Pull Request Description

Fixes regression introduced in #1705

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit added the bug Something isn't working label May 16, 2024
@shorowit shorowit self-assigned this May 16, 2024
@shorowit shorowit merged commit ed39bd7 into master May 17, 2024
@shorowit shorowit deleted the skylight_bugfix branch May 17, 2024 03:21
@joseph-robertson joseph-robertson mentioned this pull request May 19, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shorowit shorowit

Labels
bug Something isn't working
Projects
OpenStudio-HPXML
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@shorowit