Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Improvements #120

Merged
merged 10 commits into from May 16, 2024
Merged

Package Improvements #120

merged 10 commits into from May 16, 2024

Conversation

mnblonsky
Copy link
Collaborator

@mnblonsky mnblonsky commented Apr 29, 2024

Addresses #100, #102

  • Reference the issue your PR is fixing
  • Assign at least 1 reviewer for your PR
  • Test with run_dwelling.py or other script
  • Update documentation as appropriate
  • Update changelog as appropriate

@mnblonsky mnblonsky self-assigned this Apr 29, 2024
@mnblonsky mnblonsky marked this pull request as ready for review April 29, 2024 22:56
@mnblonsky
Copy link
Collaborator Author

@jmaguire1 I think this is ready for review. It would be nice to do more package dependency tests, but until we have CI/Github Actions integrated, I think it will take too much time.

Maybe we keep #100 open for now or merge it into #23. I think this fully addresses #102 though.

@mnblonsky mnblonsky marked this pull request as draft May 2, 2024 15:36
@mnblonsky mnblonsky marked this pull request as ready for review May 15, 2024 21:47
@mnblonsky
Copy link
Collaborator Author

This fully addresses #100 now. Ready for review and then merge!

@jmaguire1 jmaguire1 merged commit 6c5b7bc into dev May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants