Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Improvements #120

Merged
merged 10 commits into from
May 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Contact: jeff.maguire@nrel.gov, michael.blonsky@nrel.gov, killian.mckenna@nrel.g

## Installation

Note that OCHRE requires Python version 3.9 or higher
Note that OCHRE requires Python version >=3.9 and <3.12

### Stand-alone Installation

Expand Down
3 changes: 3 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
- Added EV max power and max SOC controls
- Added OCHREException class to handle errors
- Added warnings for HVAC and WH heat pumps with low COP
- Moved default input file path for package installation
- Replaced setup.py with pyproject.toml
- Fixed bug with schedule file import using Pandas v2.2
- Fixed bug with accounting for HVAC delivered heat for standalone HVAC runs
- Fixed bug with ASHP backup heater units
Expand All @@ -23,6 +25,7 @@
- Fixed bug with battery/generator self-consumption controls
- Fixed bug with WH and battery islanding time metrics
- Fixed bug with state space model reduction algorithm
- Fixed syntax warning for Python 3.12

### OCHRE v0.8.4-beta

Expand Down
35,043 changes: 0 additions & 35,043 deletions defaults/Weather/sample_SAM_weather.csv

This file was deleted.

2 changes: 1 addition & 1 deletion ochre/CreateFigures.py
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ def plot_wh(dfs_to_plot, **kwargs):
if ax1 is not None:
ax1[0].set_ylabel('Hot Water Delivered (W)')
ax2[0].set_ylabel('Hot Water Delivered (L/min)')
ax1[1].set_ylabel('Temperature ($^\circ$C)')
ax1[1].set_ylabel('Temperature ($^\\circ$C)')

# plot water heater power and COP
plot_info = [('Water Heating Electric Power (kW)', 'Electric Power', 'm'),
Expand Down
2 changes: 1 addition & 1 deletion ochre/Simulator.py
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ def finalize(self, failed=False):

elif self.output_to_parquet:
output_files = [os.path.join(self.output_path, f) for f in os.listdir(self.output_path)
if re.match(f'{self.name}.*\.parquet', f) and '_schedule.parquet' not in f]
if re.match(f'{self.name}.*\\.parquet', f) and '_schedule.parquet' not in f]
dfs = [pd.read_parquet(f) for f in sorted(output_files)]
if self.results:
# add recent results that haven't been saved to a parquet file
Expand Down