New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare verisons of dependencies #100
Comments
Thanks for adding this. We'll make sure we get to it before the next release. |
We have another dependency issue too. OCHRE only works with pandas>=1.4 and <=2.0.3. We'll make sure the latest pandas is supported in the next release |
I think this is partially addressed in #120. I restricted python to <3.12. We fixed the pandas issue, so no need to restrict that. We haven't fully tested compatibility for other dependencies, but I think we can update those as we find issues. |
If ochre is ready to be used by people outside of your dev team, please add versioning requirements to the dependencies! You never know when, for instance, Pandas will release version 3.0.0 and break something ochre depends on. Since you support both Pandas 1 & 2, you can't use compatible-release versioning, you'd have to do something like Might also be nice to remind yourself with a comment that numba is the reason you can't support python 3.12, so a new version of numba would allow you to relax that requirement. |
I'm testing with python 12 too, I'll add that back in if there's still a compatibility issue |
@mnblonsky I like it!
|
Addressed both of those, and Python 3.12 works. Thanks for the review! |
The text was updated successfully, but these errors were encountered: