Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streams: Set creator for some initial streams in populate_db. #30082

Merged
merged 1 commit into from
May 15, 2024

Conversation

tnmkr
Copy link
Collaborator

@tnmkr tnmkr commented May 14, 2024

Fixes: #29425 (comment)

Screenshots and screen captures:

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@tnmkr tnmkr force-pushed the creator_populatedb branch 3 times, most recently from 694d9fd to 0e898f1 Compare May 15, 2024 04:57
@tnmkr tnmkr marked this pull request as ready for review May 15, 2024 05:32
This is a follow-up to zulip#29425. It assigns creator to three streams
that are used in tests and another two that aren't. For tests,
we assign a guest, an admin and an owner as creator.
@tnmkr
Copy link
Collaborator Author

tnmkr commented May 15, 2024

@timabbott This PR is ready for review. It is a follow up.


It might be worth a follow-up change to populate_db to set creators for the initial streams, which might then require changing this test.

Originally posted by @timabbott in #29425 (comment)

@alya alya added the integration review Added by maintainers when a PR may be ready for integration. label May 15, 2024
@timabbott
Copy link
Sponsor Member

Small comment on quoting people -- you can use GitHub's quote feature to make a more visible blockquote element.

@timabbott timabbott merged commit 51635c8 into zulip:main May 15, 2024
7 checks passed
@timabbott
Copy link
Sponsor Member

Looks great, merged, thanks @tnmkr!

@tnmkr tnmkr deleted the creator_populatedb branch May 29, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration review Added by maintainers when a PR may be ready for integration. size: M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants